[Upstream] - Update-istio version based on go version 1.21 #3825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spolti
reviewed
Jul 29, 2024
.gitignore
Outdated
| @@ -74,3 +74,6 @@ docker-compose.yml | |||
|
|
|||
| # Istio installer downloaded by quick install | |||
| istio-* | |||
|
|
|||
| #Notes on how different versions of the repo | |||
spolti
reviewed
Jul 29, 2024
go.mod
Outdated
| @@ -1,6 +1,6 @@ | |||
| module github.com/kserve/kserve | |||
|
|
|||
| go 1.21 | |||
| go 1.21 | |||
spolti
suggested changes
Aug 5, 2024
| @@ -1,10129 +0,0 @@ | |||
| //go:build !ignore_autogenerated | |||
There was a problem hiding this comment.
Can you please remove this file from your changes?
mholder6
force-pushed
the
updateistio
branch
3 times, most recently
from
087528f
to
75d4d3b
Compare
9 tasks
mholder6
changed the title
mholder6
changed the title
Signed-off-by: mholder6 <marholde@redhat.com>
Comment on lines
+32
to
+33
| k8s.io/api v0.29.0 | ||
| k8s.io/apimachinery v0.29.0 |
There was a problem hiding this comment.
Is it intended to bump these versions as well?
There was a problem hiding this comment.
I believe these automatically upgraded when running go mod tidy? After upgrading the istio libs
There was a problem hiding this comment.
@terrytangyuan, correct, see that we are pinning the k8s version here:
https://github.com/kserve/kserve/pull/3825/files#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6R141
there were some incompatibilities with this new version that need closer attention.
|
@yuzisun hi, can you please take a look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Updated the istio libraries based on go versioning 1.21
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Type of changes
Please delete options that are not relevant.
Feature/Issue validation/testing:
Please describe the tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.
Test A
Test B
Logs
Special notes for your reviewer:
Checklist:
Release note:
Re-running failed tests
/rerun-all- rerun all failed workflows./rerun-workflow <workflow name>- rerun a specific failed workflow. Only one workflow name can be specified. Multiple /rerun-workflow commands are allowed per comment.