Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin nbconvert to fix a test issue #96

Merged
merged 1 commit into from
Dec 30, 2024
Merged

Pin nbconvert to fix a test issue #96

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ dependencies = [
"MarkupSafe>=2.1",
"minio>=7.0.0,!=7.2.1",
"nbclient>=0.10.0",
"nbconvert>=6.5.1",
"nbconvert==7.1.0", # Ensure compatibility with mistune<3 as `3.1.0` has issues (see https://github.com/lepture/mistune/issues/403)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my understanding is that mistune has done something silly (they renamed parse_axt_heading) and so the dependency fix should be to exclude the broken mistune and not to limit nbconvert version

"nbdime~=4.0.1", # Cap from jupyterlab-git
"nbformat>=5.1.2",
"networkx>=2.5.1",
Expand Down
1 change: 1 addition & 0 deletions test_requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,6 @@ pytest-console-scripts
pytest_jupyter
pytest-tornasync
pytest_virtualenv
nbconvert==7.1.0
requests-mock
requests-unixsocket
Loading