Pin nbconvert to fix a test issue
#96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #96 +/- ##
==========================================
- Coverage 83.04% 83.01% -0.03%
==========================================
Files 138 138
Lines 17266 17266
Branches 480 486 +6
==========================================
- Hits 14338 14334 -4
+ Misses 2750 2749 -1
- Partials 178 183 +5 ☔ View full report in Codecov by Sentry. |
jiridanek
approved these changes
Dec 30, 2024
| @@ -34,7 +34,7 @@ dependencies = [ | |||
| "MarkupSafe>=2.1", | |||
| "minio>=7.0.0,!=7.2.1", | |||
| "nbclient>=0.10.0", | |||
| "nbconvert>=6.5.1", | |||
| "nbconvert==7.1.0", # Ensure compatibility with mistune<3 as `3.1.0` has issues (see https://github.com/lepture/mistune/issues/403) | |||
There was a problem hiding this comment.
my understanding is that mistune has done something silly (they renamed parse_axt_heading) and so the dependency fix should be to exclude the broken mistune and not to limit nbconvert version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Test Serverjobs that failed on https://github.com/opendatahub-io/elyra/actions/runs/12545186590