-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed the DSPA status update on reconciliation #651
Conversation
A new image has been built to help with testing out this PR: To use this image run the following: cd $(mktemp -d)
git clone git@github.com:opendatahub-io/data-science-pipelines-operator.git
cd data-science-pipelines-operator/
git fetch origin pull/651/head
git checkout -b pullrequest 07e8e3b476ed8cf6cf2c9b58dcec2b3e799dfb86
oc new-project opendatahub
make deploy IMG="quay.io/opendatahub/data-science-pipelines-operator:pr-651" More instructions here on how to deploy and test a Data Science Pipelines Application. |
@hbelmiro Tested both the scenarios and it worked as expected. Scenario1 Result:
Scenario2 Result :
|
I re-created the kubeflow namespace and tested out scenario1. I don't see any errors in kfp-ui now. I confirm that both the scenarios are working as expected. |
Signed-off-by: hbelmiro <helber.belmiro@gmail.com>
Signed-off-by: hbelmiro <helber.belmiro@gmail.com>
Signed-off-by: hbelmiro <helber.belmiro@gmail.com>
Signed-off-by: hbelmiro <helber.belmiro@gmail.com>
Change to PR detected. A new PR build was completed. |
Tested and works as intended: Also tested tearing down pods and DSPA status continues to update as before great work @hbelmiro ! |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: HumairAK The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The issue resolved by this Pull Request:
Resolves https://issues.redhat.com/browse/RHOAIENG-6287
Description of your changes:
This PR refactors
controllers.DSPAReconciler#Reconcile
so it updates the DSPA status correctly.Testing instructions
Scenario 1 - Successful deployment
Deploy
config/samples/v2/dspa-simple
to thekubeflow
namespace.Wait until all the pods get started.
oc get datasciencepipelinesapplication.datasciencepipelinesapplications.opendatahub.io/sample -o yaml -n kubeflow | yq .status
Scenario 2 - Deployment failure
Deploy
config/samples/v2/dspa-simple
to thean-even-longer-veeeeeeeeeeeeeeery-long-data-science-project
namespace.Wait until the deployment fails with the following message:
oc get datasciencepipelinesapplication.datasciencepipelinesapplications.opendatahub.io/sample -o yaml -n an-even-longer-veeeeeeeeeeeeeeery-long-data-science-project | yq .status
Checklist