-
Notifications
You must be signed in to change notification settings - Fork 49
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
RHOAIENG-6278 - Fixed DSPA status update on reconciliation
Signed-off-by: hbelmiro <helber.belmiro@gmail.com>
- Loading branch information
Showing
3 changed files
with
257 additions
and
110 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,191 @@ | ||
package dspastatus | ||
|
||
import ( | ||
"fmt" | ||
dspav1alpha1 "github.com/opendatahub-io/data-science-pipelines-operator/api/v1alpha1" | ||
"github.com/opendatahub-io/data-science-pipelines-operator/controllers/config" | ||
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" | ||
) | ||
|
||
type DSPAStatus interface { | ||
SetDatabaseReady() | ||
SetDatabaseNotReady(err error) | ||
|
||
SetObjStoreReady() | ||
SetObjStoreNotReady(err error) | ||
|
||
SetApiServerStatus(apiServerReady metav1.Condition) | ||
|
||
SetPersistenceAgentStatus(persistenceAgentReady metav1.Condition) | ||
|
||
SetScheduledWorkflowStatus(scheduledWorkflowReady metav1.Condition) | ||
|
||
GetConditions() []metav1.Condition | ||
} | ||
|
||
func NewDSPAStatus(dspa *dspav1alpha1.DataSciencePipelinesApplication) DSPAStatus { | ||
databaseCondition := BuildUnknownCondition(config.DatabaseAvailable) | ||
objStoreCondition := BuildUnknownCondition(config.ObjectStoreAvailable) | ||
apiServerCondition := BuildUnknownCondition(config.APIServerReady) | ||
persistenceAgentCondition := BuildUnknownCondition(config.PersistenceAgentReady) | ||
scheduledWorkflowReadyCondition := BuildUnknownCondition(config.ScheduledWorkflowReady) | ||
|
||
return &dspaStatus{ | ||
dspa: dspa, | ||
databaseAvailable: &databaseCondition, | ||
objStoreAvailable: &objStoreCondition, | ||
apiServerReady: &apiServerCondition, | ||
persistenceAgentReady: &persistenceAgentCondition, | ||
scheduledWorkflowReady: &scheduledWorkflowReadyCondition, | ||
} | ||
} | ||
|
||
type dspaStatus struct { | ||
dspa *dspav1alpha1.DataSciencePipelinesApplication | ||
databaseAvailable *metav1.Condition | ||
objStoreAvailable *metav1.Condition | ||
apiServerReady *metav1.Condition | ||
persistenceAgentReady *metav1.Condition | ||
scheduledWorkflowReady *metav1.Condition | ||
} | ||
|
||
func (s *dspaStatus) SetDatabaseNotReady(err error) { | ||
condition := BuildFalseCondition(config.DatabaseAvailable, config.FailingToDeploy, err.Error()) | ||
s.databaseAvailable = &condition | ||
} | ||
|
||
func (s *dspaStatus) SetDatabaseReady() { | ||
condition := buildTrueCondition(config.DatabaseAvailable, "Database connectivity successfully verified") | ||
s.databaseAvailable = &condition | ||
} | ||
|
||
func (s *dspaStatus) SetObjStoreReady() { | ||
condition := buildTrueCondition(config.ObjectStoreAvailable, "Object Store connectivity successfully verified") | ||
s.objStoreAvailable = &condition | ||
} | ||
|
||
func (s *dspaStatus) SetObjStoreNotReady(err error) { | ||
condition := BuildFalseCondition(config.ObjectStoreAvailable, config.FailingToDeploy, err.Error()) | ||
s.objStoreAvailable = &condition | ||
} | ||
|
||
func (s *dspaStatus) SetApiServerStatus(apiServerReady metav1.Condition) { | ||
s.apiServerReady = &apiServerReady | ||
} | ||
|
||
func (s *dspaStatus) SetPersistenceAgentStatus(persistenceAgentReady metav1.Condition) { | ||
s.persistenceAgentReady = &persistenceAgentReady | ||
} | ||
|
||
func (s *dspaStatus) SetScheduledWorkflowStatus(scheduledWorkflowReady metav1.Condition) { | ||
s.scheduledWorkflowReady = &scheduledWorkflowReady | ||
} | ||
|
||
func (s *dspaStatus) GetConditions() []metav1.Condition { | ||
componentConditions := []metav1.Condition{ | ||
*s.getDatabaseAvailableCondition(), | ||
*s.getObjStoreAvailableCondition(), | ||
*s.getApiServerReadyCondition(), | ||
*s.getPersistenceAgentReadyCondition(), | ||
*s.getScheduledWorkflowReadyCondition(), | ||
} | ||
|
||
allReady := true | ||
failureMessages := "" | ||
for _, c := range componentConditions { | ||
if c.Status == metav1.ConditionFalse || c.Status == metav1.ConditionUnknown { | ||
allReady = false | ||
failureMessages += fmt.Sprintf("%s \n", c.Message) | ||
} | ||
} | ||
|
||
var crReady metav1.Condition | ||
|
||
if allReady { | ||
crReady = metav1.Condition{ | ||
Type: config.CrReady, | ||
Status: metav1.ConditionTrue, | ||
Reason: config.MinimumReplicasAvailable, | ||
Message: "All components are ready.", | ||
LastTransitionTime: metav1.Now(), | ||
} | ||
} else { | ||
crReady = metav1.Condition{ | ||
Type: config.CrReady, | ||
Status: metav1.ConditionFalse, | ||
Reason: config.MinimumReplicasAvailable, | ||
Message: failureMessages, | ||
LastTransitionTime: metav1.Now(), | ||
} | ||
} | ||
|
||
conditions := []metav1.Condition{ | ||
*s.databaseAvailable, | ||
*s.objStoreAvailable, | ||
*s.apiServerReady, | ||
*s.persistenceAgentReady, | ||
*s.scheduledWorkflowReady, | ||
crReady, | ||
} | ||
|
||
for i, condition := range s.dspa.Status.Conditions { | ||
if condition.Status == conditions[i].Status { | ||
conditions[i].LastTransitionTime = condition.LastTransitionTime | ||
} | ||
condition.ObservedGeneration = s.dspa.Generation | ||
} | ||
|
||
return conditions | ||
} | ||
|
||
func (s *dspaStatus) getDatabaseAvailableCondition() *metav1.Condition { | ||
return s.databaseAvailable | ||
} | ||
|
||
func (s *dspaStatus) getObjStoreAvailableCondition() *metav1.Condition { | ||
return s.objStoreAvailable | ||
} | ||
|
||
func (s *dspaStatus) getApiServerReadyCondition() *metav1.Condition { | ||
return s.apiServerReady | ||
} | ||
|
||
func (s *dspaStatus) getPersistenceAgentReadyCondition() *metav1.Condition { | ||
return s.persistenceAgentReady | ||
} | ||
|
||
func (s *dspaStatus) getScheduledWorkflowReadyCondition() *metav1.Condition { | ||
return s.scheduledWorkflowReady | ||
} | ||
|
||
func buildTrueCondition(conditionType string, message string) metav1.Condition { | ||
condition := metav1.Condition{} | ||
condition.Type = conditionType | ||
condition.Status = metav1.ConditionTrue | ||
condition.Reason = conditionType | ||
condition.Message = message | ||
condition.LastTransitionTime = metav1.Now() | ||
|
||
return condition | ||
} | ||
|
||
func BuildFalseCondition(conditionType string, reason string, message string) metav1.Condition { | ||
condition := metav1.Condition{} | ||
condition.Type = conditionType | ||
condition.Status = metav1.ConditionFalse | ||
condition.Reason = reason | ||
condition.Message = message | ||
condition.LastTransitionTime = metav1.Now() | ||
|
||
return condition | ||
} | ||
|
||
func BuildUnknownCondition(conditionType string) metav1.Condition { | ||
condition := metav1.Condition{} | ||
condition.Type = conditionType | ||
condition.Status = metav1.ConditionUnknown | ||
condition.Reason = "Unknown" | ||
condition.LastTransitionTime = metav1.Now() | ||
|
||
return condition | ||
} |
Oops, something went wrong.