DSPv2

[gmfrasca]

The issue resolved by this Pull Request:

Resolves #534

Description of your changes:

Merge in dspv2 feature branch

Testing instructions

Full Testing suite required. Deploy DSPO, ensure sanity. Deploy v1 and v2 DSPAs

Checklist

• The commits are squashed in a cohesive manner and have meaningful messages.
• Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
• The developer has manually tested the changes and verified that the changes work

[dsp-developers]

A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-539
An OCP cluster where you are logged in as cluster admin is required.

To use this image run the following:

cd $(mktemp -d)
git clone git@github.com:opendatahub-io/data-science-pipelines-operator.git
cd data-science-pipelines-operator/
git fetch origin pull/539/head
git checkout -b pullrequest cd786d97ebdbca735a76a11891df824d4a448419
make deploy IMG="quay.io/opendatahub/data-science-pipelines-operator:pr-539"

More instructions here on how to deploy and test a Data Science Pipelines Application.

[HumairAK]

/hold

[hbelmiro]

There's a DSPA failing with Cannot get MLMD objects from Metadata store.

How to reproduce

Check out this branch:

gh pr checkout 539

On a fresh cluster, deploy Argo:

oc new-project argo
make argodeploy

Create the opendatahub namespace:

oc new-project opendatahub

Deploy DSPO from the branch:

make deploy IMG="quay.io/opendatahub/data-science-pipelines-operator:pr-539"

Create the kubeflow namespace:

oc new-project kubeflow

Checkout https://github.com/hbelmiro/data-science-pipelines-operator/tree/issue-498:

gh pr checkout 541

Deploy the DSPA to the kubeflow namespace:

kustomize build config/samples/v2/custom-configs | oc -n kubeflow create -f -

Get the route for the DSPA:

oc get route ds-pipeline-ui-sample -n kubeflow

Open the URL in the browser and start a new pipeline run. In the pipeline run view, you'll see the error message after a few seconds.

[dsp-developers]

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-539

[gmfrasca]

There's a DSPA failing with Cannot get MLMD objects from Metadata store.

I retested this on a couple clusters, one of which was freshly provisioned, and wasn't able to reproduce the problem. I did notice that the error message was shown on the run when first kicked off, but it very quickly resolved on its own, and i believe had to do with creating the run so soon after DSPA creation.

[hbelmiro]

/lgtm

[gregsheremeta]

/hold

let's make sure this merged while everyone is awake / around

[gregsheremeta]

/unhold

[gregsheremeta]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amadhusu, gregsheremeta, hbelmiro

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [gregsheremeta]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment