Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document supported Argo versions for v2 #536

Merged
merged 2 commits into from
Jan 16, 2024

Conversation

VaniHaripriya
Copy link
Contributor

The issue resolved by this Pull Request:

Resolves #496

Description of your changes:

Updated compatibility.yaml file with argo supported versions

Testing instructions

Run the following command to see if it reflects the changes in compatibility.md

python release.py version_doc --input_file compatibility.yaml --out_file compatibility.md

Checklist

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Copy link
Member

@DharmitD DharmitD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Tested changes locally and the matrix in compability.md is updated to add a column for argo, as expected.

@@ -68,3 +75,14 @@
ubi-minimal: 8.8
ubi-micro: 8.8
openshift: 4.11,4.12,4.13
- dsp: 1.7.x
kfp-tekton:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keep the tekton versions for any 1.x.y releases

mariadb-103: 1
ubi-minimal: 8.7
ubi-micro: 8.7
openshift: 4.11,4.12,4.13
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove 4.11 and add 4.14

@openshift-ci openshift-ci bot removed the lgtm label Jan 12, 2024
@HumairAK
Copy link
Contributor

/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented Jan 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amadhusu, HumairAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@HumairAK HumairAK merged commit 9aaf91e into opendatahub-io:dspv2 Jan 16, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants