-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Last changes for DSPv2 PoC #422
Conversation
A new image has been built to help with testing out this PR: To use this image run the following: cd $(mktemp -d)
git clone git@github.com:opendatahub-io/data-science-pipelines-operator.git
cd data-science-pipelines-operator/
git fetch origin pull/422/head
git checkout -b pullrequest 80aa2c95ca7a2799f8c49588092973fb0961bc76
make deploy IMG="quay.io/opendatahub/data-science-pipelines-operator:pr-422" More instructions here on how to deploy and test a Data Science Pipelines Application. |
80aa2c9
to
f1e301b
Compare
Change to PR detected. A new PR build was completed. |
f1e301b
to
4ee49b8
Compare
Change to PR detected. A new PR build was completed. |
4ee49b8
to
e87414e
Compare
Change to PR detected. A new PR build was completed. |
e87414e
to
3b1c8bf
Compare
Change to PR detected. A new PR build was completed. |
3b1c8bf
to
5986f7a
Compare
Change to PR detected. A new PR build was completed. |
The testing instructions need to be modified to build the image and deploy it in the |
I think it's because the DSPA CR does not explicitly says to which namespace it should be created. If that's just the issue, I'm fine with providing a DSPA CR w/ namespace info to make the instructions better to follow. |
5986f7a
to
e7c5059
Compare
Change to PR detected. A new PR build was completed. |
e7c5059
to
fa7ca32
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: HumairAK The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Change to PR detected. A new PR build was completed. |
The issue resolved by this Pull Request:
Resolves #369
Resolves #380
Description of your changes:
This PR contains the last round of required changes to have a functional Deployment of DSPv2 through the operator.
Testing instructions
NOTE: For this test, it is important stick to the namespace names, specially the DSPA deployment. There are still tasks to do before having it to support multiple namespaces.
iris-pipeline
Checklist