Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Last changes for DSPv2 PoC #422

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Conversation

rimolive
Copy link
Contributor

@rimolive rimolive commented Oct 25, 2023

The issue resolved by this Pull Request:

Resolves #369
Resolves #380

Description of your changes:

This PR contains the last round of required changes to have a functional Deployment of DSPv2 through the operator.

Testing instructions

NOTE: For this test, it is important stick to the namespace names, specially the DSPA deployment. There are still tasks to do before having it to support multiple namespaces.

  • Run the following commands to prepare the environment. NOTE: Make sure there are no other DSP installations in the testing cluster:
$ export IMAGE=quay.io/<QUAY_USERNAME>/dspo:v2
$ export DSPO_NS=data-science-pipelines-operator-v2
$ export DSPA_NS=data-science-pipelines-application-v2
$ oc new-project $DSPO_NS
$ oc new-project $DSPA_NS
$ make podman-build podman-push IMG=$IMAGE
$ make v2deploy IMG=$IMAGE V2INFRA_NS=openshift-pipelines
$ make deploy IMG=$IMAGE OPERATOR_NS=$DSPO_NS
  • Use this DSPA CR to deploy the full stack
  • Check if all pods are up and running
  • Go to the UI (oc get route ml-pipeline-ui), and upload the iris-pipeline v2 example
  • Create a run from iris-pipeline
  • Watch all the pipeline steps complete successfuly

Checklist

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@dsp-developers
Copy link
Contributor

A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-422
An OCP cluster where you are logged in as cluster admin is required.

To use this image run the following:

cd $(mktemp -d)
git clone git@github.com:opendatahub-io/data-science-pipelines-operator.git
cd data-science-pipelines-operator/
git fetch origin pull/422/head
git checkout -b pullrequest 80aa2c95ca7a2799f8c49588092973fb0961bc76
make deploy IMG="quay.io/opendatahub/data-science-pipelines-operator:pr-422"

More instructions here on how to deploy and test a Data Science Pipelines Application.

@rimolive rimolive changed the title Last changes for DSPv2 PoC [WIP] Last changes for DSPv2 PoC Oct 25, 2023
@dsp-developers
Copy link
Contributor

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-422

@dsp-developers
Copy link
Contributor

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-422

@dsp-developers
Copy link
Contributor

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-422

@dsp-developers
Copy link
Contributor

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-422

@dsp-developers
Copy link
Contributor

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-422

@rimolive rimolive changed the title [WIP] Last changes for DSPv2 PoC Last changes for DSPv2 PoC Oct 25, 2023
@DharmitD
Copy link
Member

The testing instructions need to be modified to build the image and deploy it in the DSPO namespace and not DSPA I believe.

@rimolive
Copy link
Contributor Author

The testing instructions need to be modified to build the image and deploy it in the DSPO namespace and not DSPA I believe.

I think it's because the DSPA CR does not explicitly says to which namespace it should be created. If that's just the issue, I'm fine with providing a DSPA CR w/ namespace info to make the instructions better to follow.

@dsp-developers
Copy link
Contributor

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-422

@HumairAK
Copy link
Contributor

/lgtm
/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HumairAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@HumairAK HumairAK merged commit 76e17de into opendatahub-io:dspv2 Oct 27, 2023
4 checks passed
@dsp-developers
Copy link
Contributor

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-422

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants