Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper JSON backward compatibility fix #1235

Merged
merged 4 commits into from
Jan 12, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lab/connector_coding_lab.md
Original file line number Diff line number Diff line change
Expand Up @@ -184,13 +184,13 @@ class APIClient():
```
import datetime
import json
from stix_shifter_utils.modules.base.stix_transmission.base_sync_connector import BaseSyncConnector
from stix_shifter_utils.modules.base.stix_transmission.base_json_sync_connector import BaseJsonSyncConnector
from .api_client import APIClient
from stix_shifter_utils.utils.error_response import ErrorResponder
from stix_shifter_utils.utils import logger


class Connector(BaseSyncConnector):
class Connector(BaseJsonSyncConnector):

def __init__(self, connection, configuration):
self.api_client = APIClient(connection, configuration)
Expand Down
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
from stix_shifter_utils.modules.base.stix_transmission.base_results_connector import BaseResultsConnector
from stix_shifter_utils.modules.base.stix_transmission.base_json_results_connector import BaseJsonResultsConnector
from stix_shifter_utils.utils.error_response import ErrorResponder
from stix_shifter_utils.utils import logger
import json


class ResultsConnector(BaseResultsConnector):
class ResultsConnector(BaseJsonResultsConnector):
def __init__(self, api_client):
self.api_client = api_client
self.logger = logger.set_logger(__name__)
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import json
import re
from stix_shifter_utils.modules.base.stix_transmission.base_results_connector import BaseResultsConnector
from stix_shifter_utils.modules.base.stix_transmission.base_json_results_connector import BaseJsonResultsConnector
from stix_shifter_utils.utils.error_response import ErrorResponder

MAX_LIMIT = 10000
Expand All @@ -10,7 +10,7 @@
FILE_HASHES = ["MD5", "SHA256", "SHA1"]


class ResultsConnector(BaseResultsConnector):
class ResultsConnector(BaseJsonResultsConnector):
def __init__(self, api_client):
self.api_client = api_client
self.connector = __name__.split('.')[1]
Expand Down
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
from stix_shifter_utils.modules.base.stix_transmission.base_results_connector import BaseResultsConnector
from stix_shifter_utils.modules.base.stix_transmission.base_json_results_connector import BaseJsonResultsConnector
from stix_shifter_utils.utils.error_response import ErrorResponder
from stix_shifter_utils.utils import logger

class ResultsConnector(BaseResultsConnector):
class ResultsConnector(BaseJsonResultsConnector):
def __init__(self, api_client):
self.api_client = api_client
self.logger = logger.set_logger(__name__)
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import json
from stix_shifter_utils.modules.base.stix_transmission.base_results_connector import BaseResultsConnector
from stix_shifter_utils.modules.base.stix_transmission.base_json_results_connector import BaseJsonResultsConnector
from stix_shifter_utils.utils.error_response import ErrorResponder
from stix_shifter_utils.utils import logger
from flatten_json import flatten
Expand All @@ -13,7 +13,7 @@ class AccessDeniedException(Exception):
pass


class ResultsConnector(BaseResultsConnector):
class ResultsConnector(BaseJsonResultsConnector):
# https://docs.aws.amazon.com/athena/latest/APIReference/API_GetQueryResults.html#API_GetQueryResults_RequestSyntax
# Athena MaxResults count is 1000 when calling get_query_results
ATHENA_MAX_RESULTS_SIZE = 1000
Expand Down
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
import json
from flatten_json import flatten
import copy
from stix_shifter_utils.modules.base.stix_transmission.base_results_connector import BaseResultsConnector
from stix_shifter_utils.modules.base.stix_transmission.base_json_results_connector import BaseJsonResultsConnector
from stix_shifter_utils.utils.error_response import ErrorResponder
from stix_shifter_utils.utils import logger
from stix_shifter_utils.utils.file_helper import read_json


class ResultsConnector(BaseResultsConnector):
class ResultsConnector(BaseJsonResultsConnector):
def __init__(self, client, options):
self.client = client
self.logger = logger.set_logger(__name__)
Expand Down
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
from stix_shifter_utils.modules.base.stix_transmission.base_sync_connector import BaseSyncConnector
from stix_shifter_utils.modules.base.stix_transmission.base_json_sync_connector import BaseJsonSyncConnector

import aioboto3
from json import loads


class Connector(BaseSyncConnector):
class Connector(BaseJsonSyncConnector):
def __init__(self, connection, configuration):
self.connection = connection
self.configuration = configuration
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,13 @@
import adal
import re
from flatten_json import flatten
from stix_shifter_utils.modules.base.stix_transmission.base_sync_connector import BaseSyncConnector
from stix_shifter_utils.modules.base.stix_transmission.base_json_sync_connector import BaseJsonSyncConnector
from .api_client import APIClient
from stix_shifter_utils.utils.error_response import ErrorResponder
from stix_shifter_utils.utils import logger


class Connector(BaseSyncConnector):
class Connector(BaseJsonSyncConnector):
init_error = None
max_limit = 1000

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
from stix_shifter_utils.modules.base.stix_transmission.base_results_connector import BaseResultsConnector
from stix_shifter_utils.modules.base.stix_transmission.base_json_results_connector import BaseJsonResultsConnector
import json
import time
from stix_shifter_utils.utils.error_response import ErrorResponder
Expand All @@ -10,7 +10,7 @@ class UnexpectedResponseException(Exception):
pass


class ResultsConnector(BaseResultsConnector):
class ResultsConnector(BaseJsonResultsConnector):
def __init__(self, api_client):
self.api_client = api_client
self.logger = logger.set_logger(__name__)
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import json
from stix_shifter_utils.modules.base.stix_transmission.base_sync_connector import BaseSyncConnector
from stix_shifter_utils.modules.base.stix_transmission.base_json_sync_connector import BaseJsonSyncConnector
from .api_client import APIClient
from stix_shifter_utils.utils.error_response import ErrorResponder
from stix_shifter_utils.utils import logger
Expand All @@ -11,7 +11,7 @@ class UnexpectedResponseException(Exception):
pass


class Connector(BaseSyncConnector):
class Connector(BaseJsonSyncConnector):
def __init__(self, connection, configuration):
self.api_client = APIClient(connection, configuration)
self.show_events = Connector.get_show_events_mode(connection)
Expand Down
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
import json

from stix_shifter_utils.modules.base.stix_transmission.base_results_connector import BaseResultsConnector
from stix_shifter_utils.modules.base.stix_transmission.base_json_results_connector import BaseJsonResultsConnector
from stix_shifter_utils.utils.error_response import ErrorResponder
from stix_shifter_utils.utils import logger


class ResultsConnector(BaseResultsConnector):
class ResultsConnector(BaseJsonResultsConnector):
def __init__(self, api_client):
self.api_client = api_client
self.logger = logger.set_logger(__name__)
Expand Down
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
from stix_shifter_utils.modules.base.stix_transmission.base_results_connector import BaseResultsConnector
from stix_shifter_utils.modules.base.stix_transmission.base_json_results_connector import BaseJsonResultsConnector
from stix_shifter_utils.utils import logger
import json
import re
import math

import pandas as pd

class ResultsConnector(BaseResultsConnector):
class ResultsConnector(BaseJsonResultsConnector):
def __init__(self, api_client):
self.api_client = api_client
self.logger = logger.set_logger(__name__)
Expand Down
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
import json
from stix_shifter_utils.modules.base.stix_transmission.base_sync_connector import BaseSyncConnector
from stix_shifter_utils.modules.base.stix_transmission.base_json_sync_connector import BaseJsonSyncConnector
from .api_client import APIClient
from stix_shifter_utils.utils.error_response import ErrorResponder
from stix_shifter_utils.utils import logger


class Connector(BaseSyncConnector):
class Connector(BaseJsonSyncConnector):
init_error = None
logger = logger.set_logger(__name__)
PROVIDER = 'CrowdStrike'
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
from stix_shifter_utils.modules.base.stix_transmission.base_sync_connector import BaseSyncConnector
from stix_shifter_utils.modules.base.stix_transmission.base_json_sync_connector import BaseJsonSyncConnector
from stix_shifter_utils.utils.error_response import ErrorResponder
from stix_shifter_utils.utils import logger
from .api_client import APIClient
Expand All @@ -18,7 +18,7 @@ class InvalidAuthenticationException(Exception):
pass


class Connector(BaseSyncConnector):
class Connector(BaseJsonSyncConnector):

def __init__(self, connection, configuration):
self.api_client = APIClient(connection, configuration)
Expand Down
4 changes: 2 additions & 2 deletions stix_shifter_modules/darktrace/stix_transmission/connector.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
from stix_shifter_utils.modules.base.stix_transmission.base_sync_connector import BaseSyncConnector
from stix_shifter_utils.modules.base.stix_transmission.base_json_sync_connector import BaseJsonSyncConnector
from stix_shifter_utils.utils.error_response import ErrorResponder
from stix_shifter_utils.utils import logger
from .api_client import APIClient
Expand All @@ -25,7 +25,7 @@ class InvalidAuthenticationException(Exception):
pass


class Connector(BaseSyncConnector):
class Connector(BaseJsonSyncConnector):

def __init__(self, connection, configuration):
self.api_client = APIClient(connection, configuration)
Expand Down
4 changes: 2 additions & 2 deletions stix_shifter_modules/datadog/stix_transmission/connector.py
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
import json
from stix_shifter_modules.datadog.stix_transmission.api_client import APIClient
from stix_shifter_utils.modules.base.stix_transmission.base_sync_connector import BaseSyncConnector
from stix_shifter_utils.modules.base.stix_transmission.base_json_sync_connector import BaseJsonSyncConnector
from stix_shifter_utils.utils.error_response import ErrorResponder
from stix_shifter_utils.utils import logger


class Connector(BaseSyncConnector):
class Connector(BaseJsonSyncConnector):
def __init__(self, connection, configuration):
self.api_client = APIClient(connection, configuration)
self.logger = logger.set_logger(__name__)
Expand Down
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
import datetime
import json
from stix_shifter_utils.modules.base.stix_transmission.base_sync_connector import BaseSyncConnector
from stix_shifter_utils.modules.base.stix_transmission.base_json_sync_connector import BaseJsonSyncConnector
from .api_client import APIClient
from stix_shifter_utils.utils.error_response import ErrorResponder
from stix_shifter_utils.utils import logger


class Connector(BaseSyncConnector):
class Connector(BaseJsonSyncConnector):

def __init__(self, connection, configuration):
self.api_client = APIClient(connection, configuration)
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
from stix_shifter_utils.modules.base.stix_transmission.base_sync_connector import BaseSyncConnector
from stix_shifter_utils.modules.base.stix_transmission.base_json_sync_connector import BaseJsonSyncConnector
from .api_client import APIClient
import json
from stix_shifter_utils.utils.error_response import ErrorResponder
Expand All @@ -9,7 +9,7 @@ class UnexpectedResponseException(Exception):
pass


class Connector(BaseSyncConnector):
class Connector(BaseJsonSyncConnector):
def __init__(self, connection, configuration):
self.api_client = APIClient(connection, configuration)
self.logger = logger.set_logger(__name__)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
from stix2matcher.matcher import MatchListener
from stix2validator import validate_instance

from stix_shifter_utils.modules.base.stix_transmission.base_connector import BaseConnector
from stix_shifter_utils.modules.base.stix_transmission.base_json_sync_connector import BaseJsonSyncConnector
from stix_shifter_utils.modules.base.stix_transmission.base_status_connector import Status
from stix_shifter_utils.stix_transmission.utils.RestApiClientAsync import RestApiClientAsync
from stix_shifter_utils.utils.error_response import ErrorResponder
Expand All @@ -18,7 +18,7 @@ class UnexpectedResponseException(Exception):
pass


class Connector(BaseConnector):
class Connector(BaseJsonSyncConnector):
def __init__(self, connection, configuration):
self.connector = __name__.split('.')[1]
self.connection = connection
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
from stix_shifter_utils.modules.base.stix_transmission.base_results_connector import BaseResultsConnector
from stix_shifter_utils.modules.base.stix_transmission.base_json_results_connector import BaseJsonResultsConnector
from stix_shifter_utils.utils.error_response import ErrorResponder
from stix_shifter_utils.utils import logger
import json
Expand All @@ -8,7 +8,7 @@
import re


class ResultsConnector(BaseResultsConnector):
class ResultsConnector(BaseJsonResultsConnector):
EMAIL_PATTERN = re.compile(r'(^[a-zA-Z0-9_.+-]+@[a-zA-Z0-9-]+\.[a-zA-Z0-9-.]+$)')
GCP_MAX_PAGE_SIZE = 1000

Expand Down
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
from stix_shifter_utils.modules.base.stix_transmission.base_results_connector import BaseResultsConnector
from stix_shifter_utils.modules.base.stix_transmission.base_json_results_connector import BaseJsonResultsConnector
from stix_shifter_utils.utils.error_response import ErrorResponder
from stix_shifter_utils.utils import logger
import json


class ResultsConnector(BaseResultsConnector):
class ResultsConnector(BaseJsonResultsConnector):
def __init__(self, api_client):
self.api_client = api_client
self.logger = logger.set_logger(__name__)
Expand Down
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
import json
import traceback

from stix_shifter_utils.modules.base.stix_transmission.base_results_connector import \
BaseResultsConnector
from stix_shifter_utils.modules.base.stix_transmission.base_json_results_connector import \
BaseJsonResultsConnector
from stix_shifter_utils.utils import logger
from stix_shifter_utils.utils.error_response import ErrorResponder


class ResultsConnector(BaseResultsConnector):
class ResultsConnector(BaseJsonResultsConnector):

def __init__(self, api_client):
self.api_client = api_client
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,11 @@

See: https://github.com/opencybersecurityalliance/stix-shifter/blob/develop/adapter-guide/develop-transmission-module.md
"""
from stix_shifter_utils.modules.base.stix_transmission.base_results_connector import BaseResultsConnector
from stix_shifter_utils.modules.base.stix_transmission.base_json_results_connector import BaseJsonResultsConnector
from stix_shifter_utils.utils import logger
from stix_shifter_utils.utils.error_response import ErrorResponder

class ResultsConnector(BaseResultsConnector):
class ResultsConnector(BaseJsonResultsConnector):
"""
Class that handles results connector integration.

Expand Down
4 changes: 2 additions & 2 deletions stix_shifter_modules/msatp/stix_transmission/connector.py
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
import json
import adal
from stix_shifter_utils.modules.base.stix_transmission.base_sync_connector import BaseSyncConnector
from stix_shifter_utils.modules.base.stix_transmission.base_json_sync_connector import BaseJsonSyncConnector
from .api_client import APIClient
from stix_shifter_utils.utils.error_response import ErrorResponder
from stix_shifter_utils.utils import logger
import copy


class Connector(BaseSyncConnector):
class Connector(BaseJsonSyncConnector):
init_error = None
logger = logger.set_logger(__name__)

Expand Down
4 changes: 2 additions & 2 deletions stix_shifter_modules/mysql/stix_transmission/connector.py
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
import datetime
import json
from stix_shifter_utils.modules.base.stix_transmission.base_sync_connector import BaseSyncConnector
from stix_shifter_utils.modules.base.stix_transmission.base_json_sync_connector import BaseJsonSyncConnector
from .api_client import APIClient
from stix_shifter_utils.utils.error_response import ErrorResponder
from stix_shifter_utils.utils import logger


class Connector(BaseSyncConnector):
class Connector(BaseJsonSyncConnector):

def __init__(self, connection, configuration):
self.api_client = APIClient(connection, configuration)
Expand Down
4 changes: 2 additions & 2 deletions stix_shifter_modules/onelogin/stix_transmission/connector.py
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
import datetime
import json
from stix_shifter_utils.modules.base.stix_transmission.base_sync_connector import BaseSyncConnector
from stix_shifter_utils.modules.base.stix_transmission.base_json_sync_connector import BaseJsonSyncConnector
from .api_client import APIClient
from stix_shifter_utils.utils.error_response import ErrorResponder
from stix_shifter_utils.utils import logger


class Connector(BaseSyncConnector):
class Connector(BaseJsonSyncConnector):
max_limit = 50

def __init__(self, connection, configuration):
Expand Down
Loading