Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper JSON backward compatibility fix #1235

Merged
merged 4 commits into from
Jan 12, 2023

Conversation

baulus
Copy link
Contributor

@baulus baulus commented Dec 12, 2022

…esultsConnector, fixed connectors to use new BaseResultsConnector

…esultsConnector, fixed connectors to use new BaseResultsConnector
@codecov
Copy link

codecov bot commented Dec 12, 2022

Codecov Report

Base: 84.34% // Head: 84.27% // Decreases project coverage by -0.06% ⚠️

Coverage data is based on head (21e9d4f) compared to base (774dab8).
Patch coverage: 61.42% of modified lines in pull request are covered.

Additional details and impacted files
@@               Coverage Diff                @@
##           async-round2    #1235      +/-   ##
================================================
- Coverage         84.34%   84.27%   -0.07%     
================================================
  Files               560      563       +3     
  Lines             41426    41477      +51     
================================================
+ Hits              34940    34955      +15     
- Misses             6486     6522      +36     
Impacted Files Coverage Δ
...es/aws_security_hub/stix_transmission/connector.py 0.00% <0.00%> (ø)
...es/cloudsql/stix_transmission/results_connector.py 0.00% <0.00%> (ø)
...dules/demo_template/stix_transmission/connector.py 0.00% <0.00%> (ø)
..._modules/error_test/stix_transmission/connector.py 0.00% <0.00%> (ø)
...ifter_modules/mysql/stix_transmission/connector.py 0.00% <0.00%> (ø)
...ifter_modules/proxy/stix_transmission/connector.py 0.00% <0.00%> (ø)
...es/qradar_perf_test/stix_transmission/connector.py 0.00% <0.00%> (ø)
...modules/stix_bundle/stix_transmission/connector.py 0.00% <0.00%> (ø)
...ules/base/stix_transmission/base_json_connector.py 18.18% <18.18%> (ø)
...e/stix_transmission/base_json_results_connector.py 18.18% <18.18%> (ø)
... and 39 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@baulus baulus marked this pull request as ready for review January 10, 2023 20:47
@baulus baulus changed the title Reverted BaseResultsConnector to send data as string, added new BaseR… Proper JSON backward compatibility fix Jan 10, 2023
@mdazam1942 mdazam1942 merged commit 80685fe into async-round2 Jan 12, 2023
@mdazam1942 mdazam1942 deleted the proper_json_compatibility branch January 12, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants