Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for asynchronous API calls in transmission modules #1038

Merged
merged 75 commits into from
Jan 24, 2023

Conversation

baulus
Copy link
Contributor

@baulus baulus commented Jul 12, 2022

No description provided.

Arthur Muradyan and others added 14 commits July 28, 2021 11:58
* Added async flow to transmission methods

* SECCON-13579 AWS modules async, other fixes

* Added fixes to elastic_esc and bigfix unittests, moved dependancies to stix-shifter requirements

* Added async fixes to crowdstrike and trendmicro_vision_one

* ignore tests for security_adv and guardium

* fix results_stix_async call

* aync base connector

* add sleep 0

* switch to Future

* revert  future

* revert future in test

* create query without sleep

* revert test

* rest api debug output

* cleanup, enable cert_content

* more asyncs

Co-authored-by: Yurii Klymenko <Yurii.Klymenko@ibm.com>
@baulus baulus marked this pull request as ready for review August 2, 2022 14:10
dependabot bot and others added 21 commits January 3, 2023 12:01
Bumps [boto3](https://github.com/boto/boto3) from 1.26.10 to 1.26.41.
- [Release notes](https://github.com/boto/boto3/releases)
- [Changelog](https://github.com/boto/boto3/blob/develop/CHANGELOG.rst)
- [Commits](boto/boto3@1.26.10...1.26.41)

---
updated-dependencies:
- dependency-name: boto3
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Md Azam <mdazam@ca.ibm.com>
Bumps [json-fix](https://github.com/jeff-hykin/json_fix) from 0.5.0 to 0.5.1.
- [Release notes](https://github.com/jeff-hykin/json_fix/releases)
- [Commits](jeff-hykin/json_fix@0.5.0...0.5.1)

---
updated-dependencies:
- dependency-name: json-fix
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [pyopenssl](https://github.com/pyca/pyopenssl) from 22.1.0 to 23.0.0.
- [Release notes](https://github.com/pyca/pyopenssl/releases)
- [Changelog](https://github.com/pyca/pyopenssl/blob/main/CHANGELOG.rst)
- [Commits](pyca/pyopenssl@22.1.0...23.0.0)

---
updated-dependencies:
- dependency-name: pyopenssl
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Md Azam <mdazam@ca.ibm.com>
Updated the test cases with double backslash for Windows paths.
…1259)

* Updated code to handle maximum query length limitation in darktrace.
Co-authored-by: Yurii Klymenko <Yurii.Klymenko@ibm.com>
* Async 429 too many requests error handling
* Async fixes for response object, minor fixes, unittests, reversinglabs, stix bundle BasicAuth fix
@codecov
Copy link

codecov bot commented Jan 24, 2023

Codecov Report

Base: 84.66% // Head: 84.92% // Increases project coverage by +0.26% 🎉

Coverage data is based on head (b72bfba) compared to base (40eb411).
Patch coverage: 79.61% of modified lines in pull request are covered.

Additional details and impacted files
@@                Coverage Diff                @@
##           release/5.0.x    #1038      +/-   ##
=================================================
+ Coverage          84.66%   84.92%   +0.26%     
=================================================
  Files                557      575      +18     
  Lines              41435    42551    +1116     
=================================================
+ Hits               35080    36137    +1057     
- Misses              6355     6414      +59     
Impacted Files Coverage Δ
.../stix_translation/test_aws_athena_stix_to_query.py 100.00% <ø> (ø)
...es/aws_security_hub/stix_transmission/connector.py 0.00% <0.00%> (ø)
...les/cbcloud/stix_translation/results_translator.py 20.00% <0.00%> (+0.95%) ⬆️
...s/stix_translation/test_cbcloud_stix_to_cbcloud.py 100.00% <ø> (ø)
...les/cloudsql/stix_transmission/delete_connector.py 0.00% <0.00%> (ø)
...dules/cloudsql/stix_transmission/ping_connector.py 0.00% <0.00%> (ø)
...ules/cloudsql/stix_transmission/query_connector.py 0.00% <0.00%> (ø)
...es/cloudsql/stix_transmission/results_connector.py 0.00% <0.00%> (ø)
...les/cloudsql/stix_transmission/status_connector.py 0.00% <0.00%> (ø)
...odules/darktrace/stix_transmission/error_mapper.py 100.00% <ø> (ø)
... and 298 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@delliott90 delliott90 changed the title Async round2 Support for asynchronous API calls in transmission modules Jan 24, 2023
@delliott90 delliott90 merged commit 8ee6d54 into release/5.0.x Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants