Skip to content

Commit

Permalink
Merge pull request #355 from wking/revert-runtime_validate
Browse files Browse the repository at this point in the history
Revert "Add runtime-validate command"
  • Loading branch information
Ma Shimiao authored Mar 31, 2017
2 parents 38e8560 + 2e9c755 commit 133b953
Show file tree
Hide file tree
Showing 3 changed files with 36 additions and 100 deletions.
51 changes: 36 additions & 15 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,27 +30,48 @@ INFO[0000] Bundle validation succeeded.
## Testing OCI runtimes

```sh
$ make
$ sudo make install
$ sudo oci-runtime-tool runtime-validate --runtime runc
$ sudo make RUNTIME=runc localvalidation
RUNTIME=runc go test -tags "" -v github.com/opencontainers/runtime-tools/validation
=== RUN TestValidateBasic
TAP version 13
ok 1 - root filesystem
ok 2 - hostname
ok 3 - mounts
ok 4 - capabilities
ok 5 - default symlinks
ok 6 - default file system
ok 7 - default devices
ok 8 - linux devices
ok 9 - linux process
ok 10 - masked paths
ok 11 - oom score adj
ok 12 - read only paths
ok 13 - rlimits
ok 14 - sysctls
ok 15 - uid mappings
ok 16 - gid mappings
1..16
ok 6 - default devices
ok 7 - linux devices
ok 8 - linux process
ok 9 - masked paths
ok 10 - oom score adj
ok 11 - read only paths
ok 12 - rlimits
ok 13 - sysctls
ok 14 - uid mappings
ok 15 - gid mappings
1..15
--- PASS: TestValidateBasic (0.08s)
=== RUN TestValidateSysctls
TAP version 13
ok 1 - root filesystem
ok 2 - hostname
ok 3 - mounts
ok 4 - capabilities
ok 5 - default symlinks
ok 6 - default devices
ok 7 - linux devices
ok 8 - linux process
ok 9 - masked paths
ok 10 - oom score adj
ok 11 - read only paths
ok 12 - rlimits
ok 13 - sysctls
ok 14 - uid mappings
ok 15 - gid mappings
1..15
--- PASS: TestValidateSysctls (0.20s)
PASS
ok github.com/opencontainers/runtime-tools/validation 0.281s
```

[bundle]: https://github.com/opencontainers/runtime-spec/blob/master/bundle.md
Expand Down
1 change: 0 additions & 1 deletion cmd/oci-runtime-tool/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ func main() {
app.Commands = []cli.Command{
generateCommand,
bundleValidateCommand,
runtimeValidateCommand,
}

if err := app.Run(os.Args); err != nil {
Expand Down
84 changes: 0 additions & 84 deletions cmd/oci-runtime-tool/runtime_validate.go

This file was deleted.

0 comments on commit 133b953

Please sign in to comment.