Skip to content

Commit

Permalink
README: Update to use 'make localvalidation'
Browse files Browse the repository at this point in the history
Now that that is the only remaining runtime-validation approach.  I
ran the tests with runC 1.0.0-rc2, because using 1.0.0-rc3 raised:

  $ sudo make RUNTIME=~wking/bin/runc-1.0.0-rc3 localvalidation
  RUNTIME=/home/wking/bin/runc-1.0.0-rc3 go test -tags ""  -v github.com/opencontainers/runtime-tools/validation
  === RUN   TestValidateBasic
  json: cannot unmarshal array into Go value of type specs.LinuxCapabilities
  --- FAIL: TestValidateBasic (0.03s)
          validation_test.go:87: /home/wking/bin/runc-1.0.0-rc3 failed validation: exit status 1
  === RUN   TestValidateSysctls
  json: cannot unmarshal array into Go value of type specs.LinuxCapabilities
  --- FAIL: TestValidateSysctls (0.03s)
          validation_test.go:96: /home/wking/bin/runc-1.0.0-rc3 failed validation: exit status 1
  FAIL
  exit status 1
  FAIL    github.com/opencontainers/runtime-tools/validation      0.055s
  make: *** [Makefile:40: localvalidation] Error 1

because runtime-tools hasn't adjusted to the new seccomp config yet.

Signed-off-by: W. Trevor King <wking@tremily.us>
  • Loading branch information
wking committed Mar 30, 2017
1 parent 8e3272e commit 2e9c755
Showing 1 changed file with 36 additions and 15 deletions.
51 changes: 36 additions & 15 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,27 +30,48 @@ INFO[0000] Bundle validation succeeded.
## Testing OCI runtimes

```sh
$ make
$ sudo make install
$ sudo oci-runtime-tool runtime-validate --runtime runc
$ sudo make RUNTIME=runc localvalidation
RUNTIME=runc go test -tags "" -v github.com/opencontainers/runtime-tools/validation
=== RUN TestValidateBasic
TAP version 13
ok 1 - root filesystem
ok 2 - hostname
ok 3 - mounts
ok 4 - capabilities
ok 5 - default symlinks
ok 6 - default file system
ok 7 - default devices
ok 8 - linux devices
ok 9 - linux process
ok 10 - masked paths
ok 11 - oom score adj
ok 12 - read only paths
ok 13 - rlimits
ok 14 - sysctls
ok 15 - uid mappings
ok 16 - gid mappings
1..16
ok 6 - default devices
ok 7 - linux devices
ok 8 - linux process
ok 9 - masked paths
ok 10 - oom score adj
ok 11 - read only paths
ok 12 - rlimits
ok 13 - sysctls
ok 14 - uid mappings
ok 15 - gid mappings
1..15
--- PASS: TestValidateBasic (0.08s)
=== RUN TestValidateSysctls
TAP version 13
ok 1 - root filesystem
ok 2 - hostname
ok 3 - mounts
ok 4 - capabilities
ok 5 - default symlinks
ok 6 - default devices
ok 7 - linux devices
ok 8 - linux process
ok 9 - masked paths
ok 10 - oom score adj
ok 11 - read only paths
ok 12 - rlimits
ok 13 - sysctls
ok 14 - uid mappings
ok 15 - gid mappings
1..15
--- PASS: TestValidateSysctls (0.20s)
PASS
ok github.com/opencontainers/runtime-tools/validation 0.281s
```

[bundle]: https://github.com/opencontainers/runtime-spec/blob/master/bundle.md
Expand Down

0 comments on commit 2e9c755

Please sign in to comment.