Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Config] Mount destinations MUST NOT be nested in Windows #437

Merged
merged 1 commit into from
May 19, 2016

Conversation

RobDolinMS
Copy link
Collaborator

This was raised during reviews with folks working on Windows Containers.

This squashes commits from PR #433

Signed-off-by: Rob Dolin RobDolin@microsoft.com

This was raised during reviews with folks working on Windows Containers.  

This squashes commits from PR opencontainers#433

Signed-off-by: Rob Dolin <RobDolin@microsoft.com>
@crosbymichael
Copy link
Member

LGTM

@wking
Copy link
Contributor

wking commented May 18, 2016 via email

@mrunalp
Copy link
Contributor

mrunalp commented May 19, 2016

LGTM

@mrunalp mrunalp merged commit d8d0bc6 into opencontainers:master May 19, 2016
@wking
Copy link
Contributor

wking commented Jun 5, 2016

I was thinking about this a bit more, and have a few questions:

  1. At what level are nested mounts not supported?
    a. Is it a Windows-kernel restriction? If so:

    i. Is the restriction because of a policy (e.g. “allowing nested
    mounts is an unacceptable foot-gun and will not be
    supported”), or
    ii. Is it because the kernel devs just haven't gotten around to
    adding support for it yet?

    b. If it is not a kernel restriction, is it a runtime restriction?
    If so, the same policy questions apply, as well as:

    i. Is the platform sufficiently open to support third-party
    runtimes (in which case those runtimes might support nested
    paths).

  2. What counts as a nested path? The order is significant 1, and
    I'm curious about the following cases:

    i. Mounting into a subdirectory (e.g. c:\foo followed by
    c:\foo\bar).
    ii. Mounting exactly over (e.g. c:\foo followed by c:\foo).
    iii. Mointing over a parent directory (e.g. c:\foo\bar followed by
    c:\foo).

Under a few of the (1) cases, I'd suggest relaxing this PR's MUST NOT
to a MAY NOT.

And I'm guessing that at least (2i) is illegal, but I'm not sure about
the others.

@RobDolinMS RobDolinMS deleted the patch-1 branch September 1, 2016 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants