[Config] Mount destinations MUST NOT be nested in Windows #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was raised during reviews with folks working on Windows Containers. I suspect the prohibition against nested mount destinations applies across all operating systems, but if not please feel free to edit. Signed-off-by: Rob Dolin <RobDolin@microsoft.com>
|
This is fine on linux as it is already in use today in the base format. Mount |
|
Thanks @crosbymichael. I'll update this PR. |
Per comment from Michael Crosby, updating to limit this prohibition to Windows
RobDolinMS
changed the title
|
@RobDolinMS Could you squash the commits? |
RobDolinMS
added a commit
to RobDolinMS/runtime-spec
that referenced
this pull request
May 18, 2016
This was raised during reviews with folks working on Windows Containers. This squashes commits from PR opencontainers#433 Signed-off-by: Rob Dolin <RobDolin@microsoft.com>
|
Replaced by #437 |
Mashimiao
pushed a commit
to Mashimiao/specs
that referenced
this pull request
Aug 19, 2016
This was raised during reviews with folks working on Windows Containers. This squashes commits from PR opencontainers#433 Signed-off-by: Rob Dolin <RobDolin@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was raised during reviews with folks working on Windows Containers. I suspect the prohibition against nested mount destinations applies across all operating systems, but if not please feel free to edit.
Signed-off-by: Rob Dolin RobDolin@microsoft.com