Resolved pytest errors by correctly annotating ORM relationships with Mapped type #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@peterdudfield , this PR will close #88 |
|
@peterdudfield , i think we need to update sqlalchemy version here https://github.com/openclimatefix/pv-site-datamodel/blob/main/poetry.lock#L16 to enable it on pv-site-app. To fix openclimatefix/pv-site-api#133 |
|
Looks like we still get tests failing - https://github.com/openclimatefix/pv-site-datamodel/actions/runs/8350094672/job/22855747461 |
|
can you run pytest on this repo? |
|
@peterdudfield, I checked |
|
|
|
see #110 |
|
@peterdudfield , let me check. |
|
If you make a new PR, the tests should automatically run, so you'll be able to see whats going on |
peterdudfield
added a commit
that referenced
this pull request
Mar 27, 2024
* updated version of sqlalchemy (#107) * Resolved pytest errors by correctly annotating ORM relationships with Mapped type (#108) * updated version of sqlalchemy * fixed the failing of pytest because of sqlalchemy --------- Co-authored-by: Peter Dudfield <34686298+peterdudfield@users.noreply.github.com> * lint * fix --------- Co-authored-by: Rosheen Naeem <rosheennaeem4@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Fixed pytests failing because of sqlalchemy, see also #107
Fixes #88