updated version of sqlalchemy in poetry #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roshnaeem
changed the title
|
Thanks @roshnaeem |
|
It looks like the tests failed - https://github.com/openclimatefix/pv-site-datamodel/actions/runs/8318096910/job/22759627236 Can you do a fix, test locally? and then a new PR? |
|
@peterdudfield, I tried running the test, but I was getting this error, even though i installed testcontainers. 
|
|
you have to install Its in the poetry dev dependencys - https://github.com/openclimatefix/pv-site-datamodel/blob/main/pyproject.toml#L17 |
|
@peterdudfield, yes it was a problem on my end with the python version. Fixed it and opened a PR which passes all pytests. |
peterdudfield
added a commit
that referenced
this pull request
Mar 27, 2024
* updated version of sqlalchemy (#107) * Resolved pytest errors by correctly annotating ORM relationships with Mapped type (#108) * updated version of sqlalchemy * fixed the failing of pytest because of sqlalchemy --------- Co-authored-by: Peter Dudfield <34686298+peterdudfield@users.noreply.github.com> * lint * fix --------- Co-authored-by: Rosheen Naeem <rosheennaeem4@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Updated version of
sqlalchemy.Python Versions
It worked for me with the Python 3.11 version.
I tried first with Python 3.10 which threw me the incompatible error in poetry
I faced issues with Python 3.12 too. Python 3.11 is compatible with both
poetryandsqlalchemy.Fixes #88