Icon Configuration for Languages

[lkiesow]

This patch allows users to specify icons for languages selectors displayed in the subtitle editor. Users have to specify the selectable languages anyway and the algorithm used before guessed wrong for popular languages like English.

If no icon is specified for a language, the selector will simply omit the icon and display just the label.

This fixes #825

[github-actions]

This pull request is deployed at test.editor.opencast.org/860/2022-10-28_17-01-49/ .
It might take a few minutes for it to become available.

[Arnei]

I agree with this PR. Correctly guessing all the language flags was a pipe dream anyway.

This also allows us to avoid the discussion whether country flags are sensible indicators for languages, which is nice.

Comments below are justodds and ends.

[Arnei]

We could mention that these are totally optional? Arguably that might be obvious, but it might also not be. And in that case, no one feels pressured into thinking up icons when they don't want.

Alternatively comment the list out?

[lkiesow]

I'll update the description

[Arnei]

One more comment: Since the "icons" can now be very long, it might make sense to update the icon css a bit, although I hope we can trust people who are allowed to set the config to choose sensible values :)

[github-actions]

This pull request is deployed at test.editor.opencast.org/860/2022-11-11_22-31-11/ .
It might take a few minutes for it to become available.

[github-actions]

This pull request is deployed at test.editor.opencast.org/860/2022-11-11_22-32-12/ .
It might take a few minutes for it to become available.

[lkiesow]

it might make sense to update the icon css a bit,

I kind of feel like saying that if people want to be stupid, let them be stupid ;-)
But you were thinking about something like overflow: hidden?

[Arnei]

it might make sense to update the icon css a bit,

I kind of feel like saying that if people want to be stupid, let them be stupid ;-) But you were thinking about something like overflow: hidden?

Yes, thinking about exactly that. Wouldn't spent any major on time this though if overflow: hidden for some reason does not work as expected or is not enough. Not like admins will intentionally configure the editor to look terrible, right?

[lkiesow]

Updated the style. If you now try adding hundreds of flags, you will end up with something like this:

[github-actions]

This pull request is deployed at test.editor.opencast.org/860/2022-11-23_18-55-28/ .
It might take a few minutes for it to become available.