-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change wordings in finish menu #1311
Conversation
This pull request is deployed at test.editor.opencast.org/1311/2024-04-15_12-00-05/ . |
I don't know if that change is desirable. The workflow may or may not publish the video. How about "Save and start processing"? |
I had the same thoughts when I changed the texts. I agree that we should keep "processing" and append "save" to the text. |
This pull request is deployed at test.editor.opencast.org/1311/2024-04-19_14-20-52/ . |
I have repaced the text by "Save and process changes" to make it clearer that this means the saving and processing of changes. It is also more consistent with the other labels. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me now.
Change looks fine, but i wonder how we can trigger a re-translation of this. Maybe we should rename the translation key (append |
Shouldn't Crowdin handle those cases? The English string has changed, so it comes up again for all translators. |
I don't know if that's how it works? If it is, that'd be great. |
Maybe @gregorydlogan or @lkiesow, who know how Crowdin works, want to chime in. We should document "How to handle translation" afterwards. |
From the dev meeting: We assume that changing the English translation string will prompt re-translation into the other languages in Crowdin. :) |
Will clarify in the docs as a separate PR, but yes that's my understanding. Changing the translated (non-en_US) strings is frowned upon because they will blindly be overwritten by the Crowdin bot and this can also cause merge conflicts going upwards towards Develop. |
This pull request is deployed at test.editor.opencast.org/1311/2024-05-02_06-55-25/ . |
@gregorydlogan Thanks for the clarification. I reverted the german translations. |
Change the the wording of the "Start processing" button to "Save and publish changes" to better differentiate the buttons. Additionally, this should highlight that videos can be published with this button.
I haven't changed the existing translations, as I don't know what to do with them.
Related #1131