-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: privacy statement and imprint #306
Feature request: privacy statement and imprint #306
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Played around with this a bit and what can I say, it works 👍 I'll let others comment on whether the design of the pages is in line with the admin ui design docs, and instead raise some discussions points about technical stuff below.
I would prefer if we could avoid using user-generated HTML and JSON or some other form of string map instead. This would allow us more control in the frontend to ensure everything looks well, users don't have to fiddle around with HTML, and we could get some stuff like "Tel." or "Fax" translated in the frontend so users don't have to.
But I am also not at all knowledgable about the requirements for imprints and privacy statements, so if you say they absolutely require this degree of flexiblity I'm fine with it.
In my experience at least the privacy statements need that degree of flexibility since they are highliy unique per organization and would be almost impossible to be generalized into a template of some kind (e.g. some organizations use kind of tables in their privacy statements to visualize data access). |
Unfortunate, but oh well, it's just like that sometimes :D. In that case I'm fine with approving this once you get around to the other comments. |
Sorry for the delay, had lots of other stuff to do, I addressed all your concerns- @Arnei: can you have a look now? |
This pull request has conflicts ☹ |
…print-and-privacy
app/src/i18n/org/opencastproject/adminui/languages/lang-de_DE.json
Outdated
Show resolved
Hide resolved
I did a production build run and found some warnings. |
Co-authored-by: Daniel Ziegenberg <daniel@ziegenberg.at>
Co-authored-by: Daniel Ziegenberg <daniel@ziegenberg.at>
Thanks, commitet your suggestions |
closes #297