Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: privacy statement and imprint #306

Merged

Conversation

schuettloeffel-elsa
Copy link
Contributor

@schuettloeffel-elsa schuettloeffel-elsa commented Mar 14, 2024

closes #297

image

Copy link
Member

@Arnei Arnei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Played around with this a bit and what can I say, it works 👍 I'll let others comment on whether the design of the pages is in line with the admin ui design docs, and instead raise some discussions points about technical stuff below.

I would prefer if we could avoid using user-generated HTML and JSON or some other form of string map instead. This would allow us more control in the frontend to ensure everything looks well, users don't have to fiddle around with HTML, and we could get some stuff like "Tel." or "Fax" translated in the frontend so users don't have to.
But I am also not at all knowledgable about the requirements for imprints and privacy statements, so if you say they absolutely require this degree of flexiblity I'm fine with it.

app/src/components/About.tsx Outdated Show resolved Hide resolved
app/src/components/About.tsx Outdated Show resolved Hide resolved
app/src/styles/components/_components-config.scss Outdated Show resolved Hide resolved
@schuettloeffel-elsa
Copy link
Contributor Author

I would prefer if we could avoid using user-generated HTML and JSON or some other form of string map instead. This would allow us more control in the frontend to ensure everything looks well, users don't have to fiddle around with HTML, and we could get some stuff like "Tel." or "Fax" translated in the frontend so users don't have to. But I am also not at all knowledgable about the requirements for imprints and privacy statements, so if you say they absolutely require this degree of flexiblity I'm fine with it.

In my experience at least the privacy statements need that degree of flexibility since they are highliy unique per organization and would be almost impossible to be generalized into a template of some kind (e.g. some organizations use kind of tables in their privacy statements to visualize data access).

@Arnei
Copy link
Member

Arnei commented Mar 18, 2024

I would prefer if we could avoid using user-generated HTML and JSON or some other form of string map instead. This would allow us more control in the frontend to ensure everything looks well, users don't have to fiddle around with HTML, and we could get some stuff like "Tel." or "Fax" translated in the frontend so users don't have to. But I am also not at all knowledgable about the requirements for imprints and privacy statements, so if you say they absolutely require this degree of flexiblity I'm fine with it.

In my experience at least the privacy statements need that degree of flexibility since they are highliy unique per organization and would be almost impossible to be generalized into a template of some kind (e.g. some organizations use kind of tables in their privacy statements to visualize data access).

Unfortunate, but oh well, it's just like that sometimes :D. In that case I'm fine with approving this once you get around to the other comments.

@schuettloeffel-elsa
Copy link
Contributor Author

Sorry for the delay, had lots of other stuff to do, I addressed all your concerns-

@Arnei: can you have a look now?
@gregorydlogan: I implemented a switch to turn on/off both Footer Elements, you can configure it in org.opencastproject.admin.display_about in the me.json file.

Copy link
Contributor

github-actions bot commented May 3, 2024

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

app/src/components/About.tsx Outdated Show resolved Hide resolved
app/src/components/Footer.tsx Outdated Show resolved Hide resolved
@ziegenberg
Copy link
Member

ziegenberg commented May 6, 2024

I did a production build run and found some warnings.

schuettloeffel-elsa and others added 2 commits May 6, 2024 15:52
Co-authored-by: Daniel Ziegenberg <daniel@ziegenberg.at>
Co-authored-by: Daniel Ziegenberg <daniel@ziegenberg.at>
@schuettloeffel-elsa
Copy link
Contributor Author

Thanks, commitet your suggestions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: privacy statement and imprint
4 participants