Put Less into math mode 'always'
#639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. Tested editing existing annotations, adding new content as described in the issue as well as various other actions. I did not experience any freezes anymore. |
The upgrade to v4 of Less in b154c7b introduced some changes that broke our version of Bootstrap. Specifically, division in `.less` files now has to be in parantheses by default. We fixed a few instances of that in the vendored files, but missed many others. Instead of futzing around with these files even more, this patch puts Less in a compatibility mode. **Note**: This mode is deprecated, so this is only a temporary solution, until we find the time and money to update Bootstrap. Fixes opencast#632.
JulianKniephoff
force-pushed
the
fix-less-upgrade
branch
from
d9c27dd to
cf04297
Compare
|
It now works as expected. Thx for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The upgrade to v4 of Less in b154c7b introduced some changes that broke our version of Bootstrap. Specifically, division in
.lessfiles now has to be in parantheses by default. We fixed a few instances of that in the vendored files, but missed many others.Instead of futzing around with these files even more, this patch puts Less in a compatibility mode. Note: This mode is deprecated, so this is only a temporary solution, until we find the time and money to update Bootstrap.
Fixes #632.