Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding content and editing an existing annotation (with the pen icon) is not possible #632

Closed
dagraf opened this issue Nov 26, 2024 · 1 comment · Fixed by #639
Closed

Adding content and editing an existing annotation (with the pen icon) is not possible #632

dagraf opened this issue Nov 26, 2024 · 1 comment · Fixed by #639
Assignees
@JulianKniephoff
Labels
critical

Comments

@dagraf
Copy link
Collaborator

dagraf commented Nov 26, 2024 •
edited
Loading

Branch: Stable

When I have an existing annotation and have it expanded: There is a "Pen"-Icon and a button "Inhalt hinzufügen". When I click on the pen or the button, nothing happens and the tool can not be used anymore. All clicks have no effect and a browser reload is needed.

I assume this has something to do with the new feature "Annotationsvorlagen".
@JulianKniephoff JulianKniephoff self-assigned this Nov 28, 2024
@JulianKniephoff JulianKniephoff mentioned this issue Dec 2, 2024
Merged
JulianKniephoff added a commit to JulianKniephoff/annotation-tool that referenced this issue Dec 3, 2024
@JulianKniephoff
Put Less into math mode 'always'
cf04297 
The upgrade to v4 of Less in b154c7b
introduced some changes that broke our version of Bootstrap.
Specifically, division in `.less` files now has to be in parantheses by default.
We fixed a few instances of that in the vendored files,
but missed many others.

Instead of futzing around with these files even more,
this patch puts Less in a compatibility mode.
**Note**: This mode is deprecated, so this is only a temporary solution,
until we find the time and money to update Bootstrap.

Fixes opencast#632.
@dagraf
Copy link
Collaborator Author

dagraf commented Dec 3, 2024

It now works as expected. Thx for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JulianKniephoff JulianKniephoff

Labels
critical
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Put Less into math mode 'always' JulianKniephoff/annotation-tool
2 participants
@JulianKniephoff @dagraf