feat : fingerprint authentication added in the passcode activity #2034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PratyushSingh07
force-pushed
the
new-finger-auth
branch
from
9937023
to
fb38ca0
Compare
|
@jawidMuhammadi I have opened this PR in place of PR #1901 , kindly review this |
3 tasks
PratyushSingh07
changed the title
jawidMuhammadi
requested changes
Mar 26, 2023
app/src/main/java/org/mifos/mobile/ui/activities/BiometricAuthentication.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/mifos/mobile/ui/activities/BiometricAuthentication.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/mifos/mobile/ui/activities/BiometricAuthentication.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/mifos/mobile/ui/activities/BiometricAuthentication.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/mifos/mobile/ui/activities/BiometricAuthentication.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/mifos/mobile/ui/activities/PassCodeActivity.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/mifos/mobile/ui/activities/PassCodeActivity.kt
Outdated
Show resolved
Hide resolved
|
Please resolve the conflicts |
PratyushSingh07
force-pushed
the
new-finger-auth
branch
from
d3897e9
to
e8bad79
Compare
kindly review this @jawidMuhammadi |
jawidMuhammadi
approved these changes
Apr 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1208
216406124-2182f61f-ff11-4a1f-8c00-9cb7c345c0f4.mp4
I had to make two additional changes :
Modified HomeFragment and HomeOldFragment due to the below error while building :
Changed the compileSDKVersion to 33 due to the below error:
Please make sure these boxes are checked before submitting your pull request - thanks!
Apply the
AndroidStyle.xmlstyle template to your code in Android Studio.Run the unit tests with
./gradlew checkto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.