Fingerprint authentication added in the passcode page #1901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@IOhacker @rahul-gill pardon my naivete and the constant tagging but can you please review this PR as well |
rahul-gill
reviewed
Feb 2, 2023
| @@ -15,15 +30,42 @@ import org.mifos.mobile.utils.Constants | |||
| import org.mifos.mobile.utils.MaterialDialog | |||
| import org.mifos.mobile.utils.Toaster | |||
|
|
|||
| @RequiresApi(Build.VERSION_CODES.M) | |||
There was a problem hiding this comment.
Will cause crash on api lower than M. Pull out the biometric thing seperate like this, check if device has biometric capabilities and then based on that, show the biometric prompt
There was a problem hiding this comment.
@rahul-gill on it
PratyushSingh07
force-pushed
the
fingerprint-auth
branch
from
5b58532
to
52fac26
Compare
|
@rahul-gill kindly review the changes in the PR |
3 tasks
3 tasks
|
Closing this PR in accordance with the latest PR #2034 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1208
https://user-images.githubusercontent.com/90026952/216406124-2182f61f-ff11-4a1f-8c00-9cb7c345c0f4.mp4
Above video can be summarized by the below points :
Fingerprint authentication is opened during the passcode activity
Authentication reappears after exiting the app
when setting up the new pin it doesn't ask for the fingerprint scanner
Apply the
AndroidStyle.xmlstyle template to your code in Android Studio.Run the unit tests with
./gradlew checkto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.