Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [open-zaak/open-zaak#1203] Setup configuration for retry variables #140

Merged
merged 6 commits into from
Apr 26, 2024

Conversation

stevenbal
Copy link
Contributor

@stevenbal stevenbal commented Apr 16, 2024

Fixes open-zaak/open-zaak#1203
Replacement for #70

Changes:

  • use admin configurable parameters from NotificationsConfig for retry behavior
  • keep environment variables and use them to setup NotificationsConfig with setup_configuration
  • update documentation

@stevenbal stevenbal marked this pull request as draft April 16, 2024 09:33
@stevenbal stevenbal force-pushed the feature/1203-setup-config-retry-vars branch from f9b0b9e to 6f08369 Compare April 16, 2024 09:50
@stevenbal stevenbal force-pushed the feature/1203-setup-config-retry-vars branch from c492d98 to 0cf8096 Compare April 16, 2024 10:57
@stevenbal stevenbal force-pushed the feature/1203-setup-config-retry-vars branch from 0cf8096 to ca53d93 Compare April 16, 2024 11:03
@stevenbal stevenbal force-pushed the feature/1203-setup-config-retry-vars branch from ca53d93 to b959509 Compare April 16, 2024 12:07
@stevenbal stevenbal marked this pull request as ready for review April 16, 2024 12:11
@stevenbal stevenbal requested review from annashamray and Coperh April 16, 2024 12:11
@annashamray annashamray requested a review from joeribekker April 22, 2024 15:42
src/nrc/api/tasks.py Outdated Show resolved Hide resolved
@annashamray annashamray removed the request for review from joeribekker April 22, 2024 15:51
@stevenbal stevenbal requested a review from annashamray April 23, 2024 10:33
@annashamray
Copy link
Contributor

To be honest I have no idea why tests for Postgres 10 and 11 and still pending, despite being removed from the main branch

@stevenbal
Copy link
Contributor Author

Hmm that's weird, in the actual CI job they don't show up: https://github.com/open-zaak/open-notificaties/actions/runs/8798943166

@stevenbal stevenbal closed this Apr 26, 2024
@stevenbal stevenbal reopened this Apr 26, 2024
@stevenbal stevenbal force-pushed the feature/1203-setup-config-retry-vars branch from 01217ec to 43d42f1 Compare April 26, 2024 07:54
@stevenbal
Copy link
Contributor Author

If I push a new branch it has the same issue unfortunately #146

@stevenbal stevenbal merged commit c819200 into main Apr 26, 2024
30 checks passed
@stevenbal stevenbal deleted the feature/1203-setup-config-retry-vars branch April 26, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

As admin, I want to configure Open Notificaties environment via the admin UI
2 participants