✅ [open-zaak/open-zaak#1203] Tests for configurable retry config

src/nrc/api/tests/test_notificatie.py

@@ -1,14 +1,18 @@
 from unittest.mock import patch
 
-from django.test import override_settings
+from django.test import TestCase, override_settings
 from django.utils.timezone import now
 
+import requests_mock
+from celery.exceptions import Retry
+from notifications_api_common.models import NotificationsConfig
 from rest_framework import status
 from rest_framework.reverse import reverse
 from rest_framework.test import APITestCase
 from vng_api_common.conf.api import BASE_REST_FRAMEWORK
 from vng_api_common.tests import JWTAuthMixin
 
+from nrc.api.tasks import deliver_message
 from nrc.datamodel.models import Notificatie
 from nrc.datamodel.tests.factories import (
     AbonnementFactory,
@@ -142,3 +146,56 @@ def test_notificatie_send_empty_kenmerk_value(self, mock_task):
         mock_task.assert_called_once_with(
             abon.id, msg, notificatie_id=Notificatie.objects.get().id, attempt=1
         )
+
+
+@patch("nrc.api.tasks.get_exponential_backoff_interval")
+@patch("nrc.api.tasks.NotificationsConfig.get_solo")
+@patch("nrc.api.serializers.deliver_message.retry")
+class NotificatieRetryTests(TestCase):
+    def test_notificatie_retry_use_global_config(
+        self, mock_retry, mock_config, mock_get_exponential_backoff
+    ):
+        """
+        Verify that retry variables configured on `NotificationsConfig` override the
+        variables from the settings
+        """
+        mock_config.return_value = NotificationsConfig(
+            notification_delivery_max_retries=4,
+            notification_delivery_retry_backoff=4,
+            notification_delivery_retry_backoff_max=28,
+        )
+        kanaal = KanaalFactory.create(
+            naam="zaken", filters=["bron", "zaaktype", "vertrouwelijkheidaanduiding"]
+        )
+        abon = AbonnementFactory.create(callback_url="https://example.com/callback")
+        filter_group = FilterGroupFactory.create(kanaal=kanaal, abonnement=abon)
+        FilterFactory.create(
+            filter_group=filter_group, key="bron", value="082096752011"
+        )
+        msg = {
+            "kanaal": "zaken",
+            "hoofdObject": "https://ref.tst.vng.cloud/zrc/api/v1/zaken/d7a22",
+            "resource": "status",
+            "resourceUrl": "https://ref.tst.vng.cloud/zrc/api/v1/statussen/d7a22/721c9",
+            "actie": "create",
+            "aanmaakdatum": now(),
+            "kenmerken": {
+                "bron": "082096752011",
+                "zaaktype": "example.com/api/v1/zaaktypen/5aa5c",
+                "vertrouwelijkheidaanduiding": "openbaar",
+            },
+        }
+
+        mock_retry.side_effect = Retry()
+        with requests_mock.Mocker() as m:
+            m.post(abon.callback_url, status_code=404)
+            with self.assertRaises(Retry):
+                deliver_message(abon.id, msg)
+
+        mock_get_exponential_backoff.assert_called_once_with(
+            factor=4,
+            retries=0,
+            maximum=28,
+            full_jitter=False,
+        )
+        self.assertEqual(deliver_message.max_retries, 4)