Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract diff utility and use it in weaver_forge tests #86

Merged
merged 5 commits into from
Apr 4, 2024
Merged

Extract diff utility and use it in weaver_forge tests #86

merged 5 commits into from
Apr 4, 2024

Conversation

jsuereth
Copy link
Contributor

@jsuereth jsuereth commented Apr 4, 2024

  • Extract minimal "diff" function for weaver into crate (hiding dependency on similar)
  • Update semconv_markdown_gen to use the diff crate
  • Update weaver_forge to use diff crate for test failures.

jsuereth added 2 commits April 4, 2024 18:28
@jsuereth
Migrate "diff" to crate
9315fc6 
- Move diff utility from semconv generation to crate
- Update tests for weaver_forge to use diff utility for better debugability
@jsuereth
Fix cargo fmt issues
4786b96
@jsuereth jsuereth requested a review from lquerel as a code owner April 4, 2024 22:31
@codecov Codecov
Copy link

codecov bot commented Apr 4, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (main@82b26c7). Click here to learn what that means.

Files Patch % Lines
crates/weaver_diff/src/lib.rs 0.0% 1 Missing ⚠️
Additional details and impacted files 
@@          Coverage Diff           @@
##             main     #86   +/-   ##
======================================
  Coverage        ?   63.4%           
======================================
  Files           ?      54           
  Lines           ?    3209           
  Branches        ?       0           
======================================
  Hits            ?    2037           
  Misses          ?    1172           
  Partials        ?       0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

lquerel
lquerel approved these changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@lquerel lquerel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool. Thanks

@jsuereth jsuereth merged commit 4f4f740 into open-telemetry:main Apr 4, 2024
16 checks passed
@jsuereth jsuereth deleted the pr-update-tests-with-diff branch April 4, 2024 22:50
@jsuereth jsuereth mentioned this pull request Apr 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lquerel lquerel lquerel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsuereth @lquerel