Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use 'diff' more broadly in the repo to improve testing of code/documentation generation. #77

Closed
lquerel opened this issue Apr 2, 2024 · 1 comment
Closed

Use 'diff' more broadly in the repo to improve testing of code/documentation generation. #77

lquerel opened this issue Apr 2, 2024 · 1 comment

Comments

@lquerel
Copy link
Contributor

lquerel commented Apr 2, 2024

Unit tests in weaver_forge could be improved with an approach similar to the one used here https://github.com/open-telemetry/weaver/blob/main/crates/weaver_semconv_gen/src/diff.rs#L12
@lquerel lquerel mentioned this issue Apr 2, 2024
Merged
@jsuereth
Copy link
Contributor

jsuereth commented Apr 4, 2024

Fixed by #86

@jsuereth jsuereth closed this as completed Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jsuereth @lquerel