Document the examples, including Docker instructions; add BUILDING.md, update all READMEs #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmacd
changed the title
jmacd
requested review from
lquerel,
moh-osman3 and
codeboten
as code owners
|
@codeboten deserves a bunch of credit for eliminating module inconsistencies in our dependencies! 🥳 |
jmacd
changed the title
Thank you both. This PR is just what we needed to be able to open/launch this project to a wider audience! |
Co-authored-by: Laurent Quérel <laurent.querel@gmail.com>
This was referenced Nov 10, 2023
jmacd
added a commit
that referenced
this pull request
Nov 10, 2023
This trims the dependencies of the core modules. It's been on my wishlist forever! Note in particular the obfuscation processor has some wild dependencies and I don't want them in production. No issue was filed about this, we were just stuck with all the Go module problems and doing the best we could until #92 introduced the `go.work` file now used. This PR was going to be only go.mod changes, but I observed a pre-existing test failure. Part of #96.
jmacd
added a commit
that referenced
this pull request
Nov 10, 2023
Noticed some bugs in the recent changes from #92, fixed here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR (at last!) fixes a number of outstanding Golang module issues. We now use a checked-in go.work file.
The important aspect of this change, for the go.work approach to work, involves using the OTC
builderwith its--skip-get-modulesflag set. This allows the go.work file to be used instead, and we now callgo work syncinstead.There are no more
replacestatements in any of the go.mod files, so single-line commands will now work (after the next release).The new BUILDING.md instructions explains how to build either with a local Golang toolchain, or using a Docker Golang toolchain. Each example has been tested and updated for a number of minor changes, including:
printerexample (now with fewer dependencies)Fixes #72.