Skip to content

Commit 74f0d28

Browse files
authored
Minor markdown fixes, link updates (#98)
Noticed some bugs in the recent changes from #92, fixed here.
1 parent 48336af commit 74f0d28

File tree

3 files changed

+16
-17
lines changed

3 files changed

+16
-17
lines changed

CONTRIBUTING.md

+4-3
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
11
# Contributing to the OpenTelemetry Protocol with Apache Arrow project
22

33
We want to make contributing to this project as easy and transparent
4-
as possible. Please see the OpenTelemetry
5-
[CONTRIBUTING.md](https://github.com/open-telemetry/community/blob/main/CONTRIBUTING.md)
4+
as possible. Please see the OpenTelemetry [CONTRIBUTING.md][]
65
guidelines for project-wide information, including code of conduct,
76
and contributor license agreements, copyright notices, and how to
87
engage with the OpenTelemetry community.
@@ -52,7 +51,7 @@ generated files present in the `./proto/api/collector/arrow/v1` directory.
5251

5352
### Releasing this repository
5453

55-
See the instructions in [RELEASING.md][./RELEASING.md].
54+
See the instructions in [RELEASING.md][].
5655

5756
### Local development issues
5857

@@ -75,6 +74,8 @@ the easiest way to upgrade this repository is:
7574
3. Regenerate `otelarrowcol` via `make genotelarrowcol`
7675
4. Run `go work sync` to update the other modules with fresh dependencies.
7776

77+
[CONTRIBUTING.md]: ./CONTRIBUTING.md
78+
[RELEASING.md]: ./RELEASING.md
7879
[OTCDOCS]: https://opentelemetry.io/docs/collector/
7980
[OTCGH]: https://github.com/open-telemetry/opentelemetry-collector
8081
[OACGH]: https://github.com/open-telemetry/otel-arrow-collector

README.md

+6-2
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ reference implementation.
1111
## Quick start
1212

1313
Instructions for building an OpenTelemetry Collector with the modules
14-
in this repository are provided in [`BUILDING.md`][./collector/BUILDING.md].
14+
in this repository are provided in [BUILDING.md][].
1515

1616
Examples for running the OpenTelemetry Collector with the modules in
1717
this repository are documented in
@@ -175,8 +175,12 @@ data has not been updated and this collector is still fundamentally row-oriented
175175

176176
Pull requests are welcome. For major changes, please open an issue
177177
first to discuss what you would like to change. For more information, please
178-
read [CONTRIBUTING](CONTRIBUTING.md).
178+
read [CONTRIBUTING.md][].
179179

180180
## License
181181

182182
OpenTelemetry Protocol with Apache Arrow Protocol Adapter is licensed under Apache 2.0.
183+
184+
[CONTRIBUTING.md]: ./CONTRIBUTING.md
185+
[BUILDING.md]: ./BUILDING.md
186+

collector/BUILDING.md

+6-12
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ The recommended practice for building the OpenTelemetry Collector uses
99
a [`builder` tool][BUILDER]. The builder synthesizes a Golang
1010
`go.mod` file and main package with a specific set of components. If
1111
you are trying to modify and build code in this repository, see
12-
[../CONTRIBUTING.md][CONTRIBUTING], otherwise the instructions here
12+
[CONTRIBUTING.md][], otherwise the instructions here
1313
will help you simply build the code in order to try it out.
1414

1515
## Building a collector from local sources using an installed Golang toolchain
@@ -69,19 +69,13 @@ modified for integration into a custom build and release pipeline.
6969
With Docker installed, simply run:
7070

7171
```
72-
docker build . -t otelarrowcol
72+
make docker-otelarrowcol
7373
```
7474

75-
This command is also available as `make docker-otelarrowcol`. You
76-
will be able to run the [examples][EXAMPLES] using the resulting
77-
`otelarrowcol` image, e.g.,
78-
79-
```
80-
docker run otelarrowcol --config collector/examples/bridge/edge-collector.yaml
81-
```
75+
You will now be able to run the [examples][EXAMPLES] using the
76+
resulting `otelarrowcol` image.
8277

8378
[BUILDER]: https://github.com/open-telemetry/opentelemetry-collector/blob/main/cmd/builder/README.md
84-
[CONTRIBUTING]: ../CONTRIBUTING.md
79+
[CONTRIBUTING.md]: ../CONTRIBUTING.md
8580
[EXAMPLES]: ./examples/README.md
86-
[BUILDCONFIG]: ./cmd/otelarrowcol/build-config.yaml
87-
[GCPSAMPLE]: https://github.com/GoogleCloudPlatform/opentelemetry-collector-builder-sample
81+
[BUILDCONFIG]: ./otelarrowcol-build.yaml

0 commit comments

Comments
 (0)