Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify cardinality capping should be after filtering #4228

Merged
merged 4 commits into from
Sep 27, 2024
Merged

Clarify cardinality capping should be after filtering #4228

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e924524
Clarify cardinality capping should be after filtering
cijothomas Sep 25, 2024
aec5def
move to cardinality limit section
cijothomas Sep 26, 2024
5044e7f
Merge branch 'main' into cijothomas/cardinality-limit-clarification
cijothomas Sep 26, 2024
9412e74
Merge branch 'main' into cijothomas/cardinality-limit-clarification
cijothomas Sep 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@ release.
([#4211](https://github.com/open-telemetry/opentelemetry-specification/pull/4211))
- Make all fields as identifying for Meter. Previously attributes were omitted from being identifying.
([#4161](https://github.com/open-telemetry/opentelemetry-specification/pull/4161))
- Clarify that applying cardinality limits should be done after attribute filtering.
([#4228](https://github.com/open-telemetry/opentelemetry-specification/pull/4228))

### Logs

Expand Down
4 changes: 3 additions & 1 deletion specification/metrics/sdk.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -780,7 +780,9 @@ SDKs SHOULD support being configured with a cardinality limit. The number of
unique combinations of attributes is called cardinality. For a given metric, the
cardinality limit is a hard limit on the number of [Metric
Points](./data-model.md#metric-points) that can be collected during a collection
cycle.
cycle. Cardinality limit enforcement SHOULD occur _after_ attribute filtering,
if any. This ensures users can filter undesired attributes using [views](#view)
and prevent reaching the cardinality limit.

#### Configuration

Expand Down
Loading