Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify cardinality capping should be after filtering #4228

Merged
merged 4 commits into from
Sep 27, 2024
Merged

Clarify cardinality capping should be after filtering #4228

merged 4 commits into from
Sep 27, 2024

Conversation

cijothomas
Copy link
Member

@cijothomas cijothomas commented Sep 25, 2024 •
edited
Loading

Fixes #3798

Changes

Please provide a brief description of the changes here.

For non-trivial changes, follow the change proposal process.

@cijothomas cijothomas requested review from a team as code owners September 25, 2024 23:07
reyang
reyang approved these changes Sep 26, 2024
View reviewed changes
Copy link
Member

@reyang reyang left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm okay with this change #4228 (comment).

@cijothomas cijothomas added the clarification clarify ambiguity in specification label Sep 26, 2024
@reyang reyang merged commit 0e78770 into open-telemetry:main Sep 27, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dashpole dashpole dashpole approved these changes

@reyang reyang reyang approved these changes

@trask trask trask approved these changes

@pellared pellared pellared approved these changes

@MrAlias MrAlias MrAlias approved these changes

@arminru arminru arminru approved these changes

Assignees

@carlosalberto carlosalberto

Labels
clarification clarify ambiguity in specification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

How is the cardinality limit applied when attributes are being filtered?
8 participants
@cijothomas @trask @dashpole @pellared @MrAlias @arminru @reyang @carlosalberto