Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the description of the host.image attribute #3194

Merged
merged 23 commits into from
Apr 11, 2023
Merged

Update the description of the host.image attribute #3194

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
a982cf4
clarify the host.image may be VM or host OS
sebastien-rosset Feb 9, 2023
c614d94
Merge branch 'main' into 3146
sebastien-rosset Feb 9, 2023
15ef8f2
clarify the host.image may be VM or host OS
sebastien-rosset Feb 9, 2023
279c3d4
Merge branch 'main' into 3146
sebastien-rosset Feb 10, 2023
2d55221
clarify the host.image may be VM or host OS
sebastien-rosset Feb 10, 2023
29d4c52
Merge branch 'main' into 3146
sebastien-rosset Feb 10, 2023
5c6c32c
Merge branch 'main' into 3146
sebastien-rosset Feb 26, 2023
bf9b96d
improve description
sebastien-rosset Feb 27, 2023
4b46113
Merge branch 'main' into 3146
sebastien-rosset Mar 1, 2023
2e2afb3
Merge branch 'main' into 3146
sebastien-rosset Mar 2, 2023
d938bd4
Merge branch 'main' into 3146
sebastien-rosset Mar 2, 2023
9ae0df8
Merge branch 'main' into 3146
sebastien-rosset Mar 4, 2023
8ea4f3b
Merge branch 'main' into 3146
sebastien-rosset Mar 6, 2023
52a0eaf
Merge branch 'main' into 3146
sebastien-rosset Mar 7, 2023
2b6e969
update brief description for image.version
sebastien-rosset Mar 9, 2023
d0384d0
Merge branch 'main' into 3146
sebastien-rosset Mar 9, 2023
4658690
Merge branch 'main' into 3146
sebastien-rosset Mar 11, 2023
75004a3
Merge branch 'main' into 3146
sebastien-rosset Mar 16, 2023
e2923f0
Merge branch 'main' into 3146
sebastien-rosset Mar 17, 2023
c1ca805
Merge branch 'main' into 3146
sebastien-rosset Mar 25, 2023
a07b0f5
Merge branch 'open-telemetry:main' into 3146
sebastien-rosset Apr 1, 2023
5637ed4
Merge branch 'main' into 3146
sebastien-rosset Apr 9, 2023
ab86e86
Merge branch 'main' into 3146
sebastien-rosset Apr 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions semantic_conventions/resource/host.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ groups:
prefix: host
type: resource
brief: >
A host is defined as a general computing instance.
A host is defined as a computing instance. For example, physical servers, virtual machines, switches or disk array.
attributes:
- id: id
type: string
Expand Down Expand Up @@ -61,7 +61,7 @@ groups:
- id: image.id
type: string
brief: >
VM image ID. For Cloud, this value is from the provider.
VM image ID or host OS image ID. For Cloud, this value is from the provider.
examples: ['ami-07b06b442921831e5']
- id: image.version
type: string
Expand Down
6 changes: 3 additions & 3 deletions specification/resource/semantic_conventions/host.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

**type:** `host`

**Description:** A host is defined as a general computing instance.
**Description:** A host is defined as a computing instance. For example, physical servers, virtual machines, switches or disk array.

<!-- semconv host -->
| Attribute | Type | Description | Examples | Requirement Level |
Expand All @@ -14,8 +14,8 @@
| `host.type` | string | Type of host. For Cloud, this must be the machine type. | `n1-standard-1` | Recommended |
| `host.arch` | string | The CPU architecture the host system is running on. | `amd64` | Recommended |
| `host.image.name` | string | Name of the VM image or OS install the host was instantiated from. | `infra-ami-eks-worker-node-7d4ec78312`; `CentOS-8-x86_64-1905` | Recommended |
| `host.image.id` | string | VM image ID. For Cloud, this value is from the provider. | `ami-07b06b442921831e5` | Recommended |
| `host.image.version` | string | The version string of the VM image as defined in [Version Attributes](README.md#version-attributes). | `0.1` | Recommended |
| `host.image.id` | string | VM image ID or host OS image ID. For Cloud, this value is from the provider. | `ami-07b06b442921831e5` | Recommended |
| `host.image.version` | string | The version string of the VM image or host OS as defined in [Version Attributes](README.md#version-attributes). | `0.1` | Recommended |

`host.arch` has the following list of well-known values. If one of them applies, then the respective value MUST be used, otherwise a custom value MAY be used.

Expand Down