Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the description of the host.image attribute #3194

Merged
merged 23 commits into from
Apr 11, 2023
Merged

Update the description of the host.image attribute #3194

merged 23 commits into from
Apr 11, 2023

Conversation

sebastien-rosset
Copy link
Contributor

Fixes #3146

Changes

In the metrics semantic guidelines, improve the description of the host.image attribute. The image is not necessarily a VM.

Related issues #

Related OTEP(s) #

@sebastien-rosset sebastien-rosset requested review from a team February 9, 2023 15:37
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Feb 9, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: sebastien-rosset / name: Sebastien Rosset (a982cf4)

@MrAlias
Copy link
Contributor

MrAlias commented Feb 10, 2023

The semantic conventions yaml file needs to be updated.

@sebastien-rosset
Copy link
Contributor Author

The semantic conventions yaml file needs to be updated.

I have updated semantic_conventions/resource/host.yaml

@arminru arminru added spec:resource Related to the specification/resource directory area:semantic-conventions Related to semantic conventions labels Feb 14, 2023
@SergeyKanzhelev SergeyKanzhelev removed their assignment Feb 18, 2023
@github-actions
Copy link

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Feb 26, 2023
@MrAlias MrAlias removed the Stale label Feb 26, 2023
@sebastien-rosset
Copy link
Contributor Author

I read the formatting rules, ran them and fixed some issues I discovered.

@github-actions
Copy link

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Mar 25, 2023
@sebastien-rosset
Copy link
Contributor Author

Is there anything I can do such that the PR can be merged?

@github-actions github-actions bot removed the Stale label Mar 26, 2023
@arminru arminru requested review from a team March 27, 2023 16:10
@github-actions
Copy link

github-actions bot commented Apr 9, 2023

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Apr 9, 2023
@MrAlias MrAlias removed the Stale label Apr 9, 2023
@arminru arminru merged commit b0ba0a9 into open-telemetry:main Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrAlias MrAlias MrAlias approved these changes

@arminru arminru arminru approved these changes

Assignees
No one assigned
Labels
area:semantic-conventions Related to semantic conventions spec:resource Related to the specification/resource directory
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Description of host.image.id and host.image.version should not be specific to VMs
4 participants
@sebastien-rosset @MrAlias @arminru @SergeyKanzhelev