Have consistent naming for Google Cloud services #1496
Conversation
`gcp_gke` is the only value that contains a shorten version of the cloud service in cloud semantic conventions. Use the long name to have consistency with others. Also update the briefs the use the fully qualified names of Google Cloud services. Fixes #1485.
| value: 'gcp_gke' | ||
| brief: Google Cloud Run | ||
| - id: GCP_KubernetesEngine | ||
| value: 'gcp_kubernetes_engine' | ||
| brief: Google Kubernetes Engine |
There was a problem hiding this comment.
| brief: Google Kubernetes Engine | |
| brief: Google Cloud Kubernetes Engine |
There was a problem hiding this comment.
+1 to @arminru comment, see: https://cloud.google.com/kubernetes-engine for the branded product name
| @@ -78,19 +78,19 @@ groups: | |||
| brief: Azure App Service | |||
| - id: GCP_ComputeEngine | |||
| value: 'gcp_compute_engine' | |||
| brief: GCP Compute Engine | |||
| brief: Google Compute Engine | |||
There was a problem hiding this comment.
| brief: Google Compute Engine | |
| brief: Google Cloud Compute Engine |
There was a problem hiding this comment.
Their brand name is actually Google Kubernetes/Compute Engine (GKE and GCE) without "Cloud" so it should be fine.
| @@ -78,19 +78,19 @@ groups: | |||
| brief: Azure App Service | |||
| - id: GCP_ComputeEngine | |||
| value: 'gcp_compute_engine' | |||
| brief: GCP Compute Engine | |||
| brief: Google Compute Engine | |||
There was a problem hiding this comment.
Their brand name is actually Google Kubernetes/Compute Engine (GKE and GCE) without "Cloud" so it should be fine.
| @@ -78,19 +78,19 @@ groups: | |||
| brief: Azure App Service | |||
| - id: GCP_ComputeEngine | |||
| value: 'gcp_compute_engine' | |||
| brief: GCP Compute Engine | |||
| brief: Google Compute Engine | |||
There was a problem hiding this comment.
| brief: Google Compute Engine | |
| brief: Google Compute Engine (GCE) |
| value: 'gcp_gke' | ||
| brief: Google Cloud Run | ||
| - id: GCP_KubernetesEngine | ||
| value: 'gcp_kubernetes_engine' | ||
| brief: Google Kubernetes Engine |
There was a problem hiding this comment.
| brief: Google Kubernetes Engine | |
| brief: Google Kubernetes Engine (GKE) |
There was a problem hiding this comment.
I think we should be consistent with acronym usage across this whole file. EKS, e.g. is branded as Amazon Elastic Kubernetes Engine. If we're going to call out an acronym here, is there a reason we wouldn't use it in the value field to be consistent across cloud offerings?
Just want to understand what judgement call / criteria we're using for naming here so we're consistent across all offerings.
| value: 'gcp_gke' | ||
| brief: Google Cloud Run | ||
| - id: GCP_KubernetesEngine | ||
| value: 'gcp_kubernetes_engine' | ||
| brief: Google Kubernetes Engine |
| - id: GCP_AppEngine | ||
| value: 'gcp_app_engine' | ||
| brief: GCP App Engine | ||
| brief: Google Cloud App Engine |
There was a problem hiding this comment.
| brief: Google Cloud App Engine | |
| brief: Google App Engine (GAE) |
| @@ -78,19 +78,19 @@ groups: | |||
| brief: Azure App Service | |||
| - id: GCP_ComputeEngine | |||
| value: 'gcp_compute_engine' | |||
| brief: GCP Compute Engine | |||
| brief: Google Compute Engine | |||
| @@ -78,19 +78,19 @@ groups: | |||
| brief: Azure App Service | |||
| - id: GCP_ComputeEngine | |||
| value: 'gcp_compute_engine' | |||
| brief: GCP Compute Engine | |||
| brief: Google Compute Engine | |||
|
@jsuereth does it look good to go? |
gcp_gkeis the only value that contains a shorten version of thecloud service in cloud semantic conventions.
Use the long name to have consistency with others.
Also update the briefs the use the fully qualified names
of Google Cloud services.
Fixes #1485.