Skip to content

Commit

Permalink
Have consistent naming for Google Cloud services (open-telemetry#1496)
Browse files Browse the repository at this point in the history
  • Loading branch information
rakyll authored and ThomsonTan committed Mar 30, 2021
1 parent 5d0ff08 commit df8c544
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 12 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ release.
- Add [`ForceFlush`](https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/sdk.md#forceflush) to SDK's `TracerProvider` ([#1452](https://github.com/open-telemetry/opentelemetry-specification/pull/1452))
- Add `elasticsearch` to `db.system` semantic conventions ([#1463](https://github.com/open-telemetry/opentelemetry-specification/pull/1463))
- Add `runtime` to `container` semantic conventions ([#1482](https://github.com/open-telemetry/opentelemetry-specification/pull/1482))
- Rename `gcp_gke` to `gcp_kubernetes_engine` to have consistency with other
Google products under `cloud.infrastructure_service` ([#1496](https://github.com/open-telemetry/opentelemetry-specification/pull/1496))

## v1.0.1 (2021-02-11)

Expand Down
14 changes: 7 additions & 7 deletions semantic_conventions/resource/cloud.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -78,19 +78,19 @@ groups:
brief: Azure App Service
- id: GCP_ComputeEngine
value: 'gcp_compute_engine'
brief: GCP Compute Engine
brief: Google Cloud Compute Engine (GCE)
- id: GCP_CloudRun
value: 'gcp_cloud_run'
brief: GCP Cloud Run
- id: GCP_GKE
value: 'gcp_gke'
brief: Google Kubernetes Engine
brief: Google Cloud Run
- id: GCP_KubernetesEngine
value: 'gcp_kubernetes_engine'
brief: Google Cloud Kubernetes Engine (GKE)
- id: GCP_CloudFunctions
value: 'gcp_cloud_functions'
brief: GCP Cloud Functions
brief: Google Cloud Functions (GCF)
- id: GCP_AppEngine
value: 'gcp_app_engine'
brief: GCP App Engine
brief: Google Cloud App Engine (GAE)
brief: >
The cloud infrastructure resource in use.
note: >
Expand Down
10 changes: 5 additions & 5 deletions specification/resource/semantic_conventions/cloud.md
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,9 @@
| `azure_aks` | Azure Kubernetes Service |
| `azure_functions` | Azure Functions |
| `azure_app_service` | Azure App Service |
| `gcp_compute_engine` | GCP Compute Engine |
| `gcp_cloud_run` | GCP Cloud Run |
| `gcp_gke` | Google Kubernetes Engine |
| `gcp_cloud_functions` | GCP Cloud Functions |
| `gcp_app_engine` | GCP App Engine |
| `gcp_compute_engine` | Google Cloud Compute Engine (GCE) |
| `gcp_cloud_run` | Google Cloud Run |
| `gcp_kubernetes_engine` | Google Cloud Kubernetes Engine (GKE) |
| `gcp_cloud_functions` | Google Cloud Functions (GCF) |
| `gcp_app_engine` | Google Cloud App Engine (GAE) |
<!-- endsemconv -->

0 comments on commit df8c544

Please sign in to comment.