[zpage] initial implementation #595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #595 +/- ##
=====================================
Coverage 54.7% 54.7%
=====================================
Files 101 101
Lines 8943 8943
=====================================
Hits 4897 4897
Misses 4046 4046
Continue to review full report at Codecov.
|
jtescher
approved these changes
Jul 25, 2021
There was a problem hiding this comment.
This looks like a great start! Should we add a note about the experimental status in the readme? seems to be suggested in https://github.com/open-telemetry/opentelemetry-specification/tree/main/experimental
* Added proto. * We use a dedicated SpanAggregator to collect information from ZPagesProcessor so that we could collect information from multiple span processor in the future should we needed to do so. * Always copy SpanData information and send it to aggregator. It may seems unnecessary to refresh the information on running span whenever a span is started. But consider that if the span is generating too fast. Some span may fail to notify the aggregator they already ended. So to make sure no span is stuck as running span example. We refresh the running span example whenever there is a new span started.
We aggregate the information for running spans, error spans and spans in different latencies bucket into SpanStats to better manage them.
* Updated proto.
…ries. 1. We use counts to trace the total number of spans. It's different from the len because len function tracks the number of sampled spans. 2. Added examples on how to query tracez results.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related #269.
Adding a
tracezimplementation to debug spans.It consists of three parts: a
ZPageSpanProcessorto install with theTracerProvider; aSpanAggregatorto accumulate the sample spans; a channel to send query requests toSpanAggregator.We probably can extract the protobuf related transform into a separate crate(
opentelemetry-protomaybe?) to be shared betweenopentelemetry-otlpandopentelemetry-zpage.Another limitation is we cannot record the status of the running spans as it requires we keep an immutable reference to the span. I don't think it's possible without introducing a lock inside the span. #602
Note to reviewers:
transform.rscontains duplicate code fromopentelemetry-otlpto transform between protobuf generated types and internal types.