Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add experimental zpages #269

Closed
jtescher opened this issue Oct 14, 2020 · 3 comments
Closed

Add experimental zpages #269

jtescher opened this issue Oct 14, 2020 · 3 comments
Assignees
Labels
help wanted Good for taking. Extra help will be provided by maintainers/approvers

Comments

@jtescher
Copy link
Member

See the spec change for details open-telemetry/opentelemetry-specification#890

@jtescher jtescher added the help wanted Good for taking. Extra help will be provided by maintainers/approvers label Oct 17, 2020
@TommyCpp
Copy link
Contributor

TommyCpp commented Oct 23, 2020

I think currently zPages should contain following components:

  1. a custom span processor(zPage processor I guess) to collect spans.
  2. an aggregatorto collect sample span, and record related metrics (running, error, latency buckets counts, etc.)
  3. a http server to serve those data to users.

I'd image we could combine aggregator and http server and let them running in backgroud where zPage processor "export" spans through a channel shared with aggregator. If those sounds like a good start. I could dig around and work on it to see if there is any catch.

@jtescher
Copy link
Member Author

@TommyCpp I haven't looked to much into it, but that sounds reasonable to me

@jtescher
Copy link
Member Author

Completed in #595

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Good for taking. Extra help will be provided by maintainers/approvers
Projects
None yet
Development

No branches or pull requests

2 participants