Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default propagator to noop #329

Merged
merged 2 commits into from
Nov 2, 2020

Conversation

morigs
Copy link
Contributor

@morigs morigs commented Nov 2, 2020

Resolves #221

@morigs morigs requested a review from a team November 2, 2020 07:16
@codecov
Copy link

codecov bot commented Nov 2, 2020

Codecov Report

Merging #329 into master will increase coverage by 0.14%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #329      +/-   ##
==========================================
+ Coverage   53.27%   53.42%   +0.14%     
==========================================
  Files          71       71              
  Lines        5800     5818      +18     
==========================================
+ Hits         3090     3108      +18     
  Misses       2710     2710              
Impacted Files Coverage Δ
opentelemetry/src/sdk/propagation/composite.rs 95.45% <100.00%> (+0.71%) ⬆️
...ntelemetry/src/sdk/metrics/aggregators/ddsketch.rs 78.59% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e87c435...1d4000b. Read the comment docs.

@jtescher
Copy link
Member

jtescher commented Nov 2, 2020

Looks like the CLA bot is stuck again

@jtescher jtescher merged commit 866ae41 into open-telemetry:master Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the default propagator to be noop
3 participants