Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the default propagator to be noop #221

Closed
jtescher opened this issue Sep 18, 2020 · 4 comments · Fixed by #329
Closed

Update the default propagator to be noop #221

jtescher opened this issue Sep 18, 2020 · 4 comments · Fixed by #329
Labels
good first issue Good for newcomers

Comments

@jtescher
Copy link
Member

See the spec change for details.

@morigs
Copy link
Contributor

morigs commented Oct 21, 2020

Do I understand correctly that the noop propagator has not yet been implemented?

And the main change is to replace composite propagator here with noop?

@frigus02
Copy link
Member

Yes, that is exactly how I understand it as well. There is no NoopPropagator, yet. So we need to implement one. And we need to make the noop propagator the new default. The location you linked is correct.

@morigs
Copy link
Contributor

morigs commented Oct 22, 2020

Looking at the Go implementation. They use empty composite text map propagator
It seems this is possible with current CompositeTextMapPropagator implementation

@frigus02
Copy link
Member

Oh yes. That sounds good to me 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants