Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add speced out environment variables and arguments for BatchLogRecordProcessor #3237

Merged
merged 5 commits into from
Mar 31, 2023

Conversation

jeremydvoss
Copy link
Contributor

@jeremydvoss jeremydvoss commented Mar 24, 2023

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #3244

Type of change

Please delete options that are not relevant.

In order to avoid a breaking change, I moved the new BLRP arg, max_queue_size, to the end of the arg list. It is the first argument for BSP.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Tests for the defaulting logic of the BLRP args, their env vars, and their validation.

Does This PR Require a Contrib Repo Change?

Answer the following question based on these examples of changes that would require a Contrib Repo Change:

  • The OTel specification has changed which prompted this PR to update the method interfaces of opentelemetry-api/ or opentelemetry-sdk/

  • The method interfaces of test/util have changed

  • Scripts in scripts/ that were copied over to the Contrib repo have changed

  • Configuration files that were copied over to the Contrib repo have changed (when consistency between repositories is applicable) such as in

    • pyproject.toml
    • isort.cfg
    • .flake8
  • When a new .github/CODEOWNER is added

  • Major changes to project information, such as in:

    • README.md
    • CONTRIBUTING.md
  • Yes. - Link to PR:

  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@jeremydvoss jeremydvoss changed the title Log export env var Add speced out environment variables and arguments for BatchLogRecordProcessor Mar 24, 2023
@jeremydvoss
Copy link
Contributor Author

Tests are failing with the following error:
note: This error originates from a subprocess, and is likely not a problem with pip.
ERROR: InvocationError for command 'D:\a\opentelemetry-python\opentelemetry-python.tox\py38-opentelemetry-getting-started\Scripts\pip.EXE' install -e 'git+https://github.com/open-telemetry/opentelemetry-python-contrib.git@7fb0340445f5e0164bc59a3af1bf5836393013f4#egg=opentelemetry-util-http&subdirectory=util/opentelemetry-util-http' (exited with code 1)
___________________________________ summary ___________________________________
ERROR: py38-opentelemetry-getting-started: commands failed

@jeremydvoss jeremydvoss marked this pull request as ready for review March 24, 2023 18:22
@jeremydvoss jeremydvoss requested a review from a team March 24, 2023 18:22
@jeremydvoss
Copy link
Contributor Author

#3235

@lzchen lzchen added the Approve Public API check This label shows that the public symbols added or changed in a PR are strictly necessary label Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approve Public API check This label shows that the public symbols added or changed in a PR are strictly necessary
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support BLRP Environment Variables
3 participants