Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OpenCensus shim to update OpenCensus execution context #3231

Merged
merged 7 commits into from
Apr 3, 2023

Conversation

aabmass
Copy link
Member

@aabmass aabmass commented Mar 22, 2023

Description

Update OpenCensus shim to update OpenCensus execution context

Previously, the shim was only writing to OTel context. This updates it to write to both OC and OTel.

Also updated the code to use the span_context provided when instrumentation instantiates the Tracer.

Part of #3203

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Added lots of tests

Does This PR Require a Contrib Repo Change?

Answer the following question based on these examples of changes that would require a Contrib Repo Change:

  • The OTel specification has changed which prompted this PR to update the method interfaces of opentelemetry-api/ or opentelemetry-sdk/

  • The method interfaces of test/util have changed

  • Scripts in scripts/ that were copied over to the Contrib repo have changed

  • Configuration files that were copied over to the Contrib repo have changed (when consistency between repositories is applicable) such as in

    • pyproject.toml
    • isort.cfg
    • .flake8
  • When a new .github/CODEOWNER is added

  • Major changes to project information, such as in:

    • README.md
    • CONTRIBUTING.md
  • Yes. - Link to PR:

  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated – skipping as this package has never been released.
  • Unit tests have been added
  • Documentation has been updated

@aabmass aabmass force-pushed the pr3231 branch 2 times, most recently from 26bc505 to beb4747 Compare March 22, 2023 17:46
Previously, the shim was only writing to OTel context. This updates it to write to both OC and OTel.

Also updated the code to use the `span_context` provided when instrumentation instantiates the `Tracer`.
@aabmass aabmass added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Mar 22, 2023
@aabmass aabmass marked this pull request as ready for review March 22, 2023 22:53
@aabmass aabmass requested a review from a team March 22, 2023 22:53
@srikanthccv srikanthccv merged commit 17aa1e8 into open-telemetry:main Apr 3, 2023
@aabmass aabmass deleted the pr3231 branch April 3, 2023 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants