-
Notifications
You must be signed in to change notification settings - Fork 610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update OpenCensus shim to update OpenCensus execution context #3231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aabmass
force-pushed
the
pr3231
branch
2 times, most recently
from
March 22, 2023 17:46
26bc505
to
beb4747
Compare
Previously, the shim was only writing to OTel context. This updates it to write to both OC and OTel. Also updated the code to use the `span_context` provided when instrumentation instantiates the `Tracer`.
lzchen
reviewed
Mar 27, 2023
shim/opentelemetry-opencensus-shim/src/opentelemetry/shim/opencensus/_shim_tracer.py
Show resolved
Hide resolved
lzchen
reviewed
Mar 27, 2023
shim/opentelemetry-opencensus-shim/src/opentelemetry/shim/opencensus/_shim_tracer.py
Show resolved
Hide resolved
lzchen
reviewed
Mar 27, 2023
shim/opentelemetry-opencensus-shim/src/opentelemetry/shim/opencensus/_shim_tracer.py
Show resolved
Hide resolved
lzchen
reviewed
Mar 27, 2023
shim/opentelemetry-opencensus-shim/src/opentelemetry/shim/opencensus/_shim_tracer.py
Show resolved
Hide resolved
lzchen
approved these changes
Mar 29, 2023
ocelotl
reviewed
Mar 30, 2023
shim/opentelemetry-opencensus-shim/src/opentelemetry/shim/opencensus/_patch.py
Show resolved
Hide resolved
ocelotl
reviewed
Mar 30, 2023
shim/opentelemetry-opencensus-shim/src/opentelemetry/shim/opencensus/_shim_span.py
Outdated
Show resolved
Hide resolved
ocelotl
approved these changes
Mar 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update OpenCensus shim to update OpenCensus execution context
Previously, the shim was only writing to OTel context. This updates it to write to both OC and OTel.
Also updated the code to use the
span_context
provided when instrumentation instantiates theTracer
.Part of #3203
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Contrib Repo Change?
Answer the following question based on these examples of changes that would require a Contrib Repo Change:
The OTel specification has changed which prompted this PR to update the method interfaces of
opentelemetry-api/
oropentelemetry-sdk/
The method interfaces of
test/util
have changedScripts in
scripts/
that were copied over to the Contrib repo have changedConfiguration files that were copied over to the Contrib repo have changed (when consistency between repositories is applicable) such as in
pyproject.toml
isort.cfg
.flake8
When a new
.github/CODEOWNER
is addedMajor changes to project information, such as in:
README.md
CONTRIBUTING.md
Yes. - Link to PR:
No.
Checklist: