-
Notifications
You must be signed in to change notification settings - Fork 657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #1848 opentracing shim exception reporting #1878
Fix #1848 opentracing shim exception reporting #1878
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice if you can also include exception.type
and exception.stacktrace
in test.
Thanks @lonewolf3739, I've added a couple, once the CI jobs are approved (and pass) is there anything else needed for merging? |
62f64f1
to
93de441
Compare
93de441
to
4fdc129
Compare
@robertsben Please take a look at the failing tests. Once they are fixed, one of maintainers will merge this. |
Sorry I'd missed a couple originally. Everything is now passing, except the |
Description
This PR looks to address the issue where the opentracing-shim is not reporting errors correctly in the opentelemetry specification format.
Fixes #1848
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
This has been tested by installing the branch as an editable requirement (
pip -e
) in a minimal working example, exporting traces to jaeger and elastic APM via an opentelemetry-collector and using the opentracing-shim. To reproduce checkout the fix branch of that repo and follow instructions in the README.Does This PR Require a Contrib Repo Change?
Answer the following question based on these examples of changes that would require a Contrib Repo Change:
The OTel specification has changed which prompted this PR to update the method interfaces of
opentelemetry-api/
oropentelemetry-sdk/
The method interfaces of
test/util
have changedScripts in
scripts/
that were copied over to the Contrib repo have changedConfiguration files that were copied over to the Contrib repo have changed (when consistency between repositories is applicable) such as in
pyproject.toml
isort.cfg
.flake8
When a new
.github/CODEOWNER
is addedMajor changes to project information, such as in:
README.md
CONTRIBUTING.md
Yes. - Link to PR:
No.
Checklist: