Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update opentracing shim to map errors from logs #1848

Closed
codeboten opened this issue May 12, 2021 · 2 comments · Fixed by #1878
Closed

Update opentracing shim to map errors from logs #1848

codeboten opened this issue May 12, 2021 · 2 comments · Fixed by #1878

Comments

@codeboten
Copy link
Contributor

As per spec:

The Add Event's name parameter MUST be the value with the event key in the pair set, or else fallback to use the log literal string.

If pair set contains a event=error entry, the values MUST be mapped from OpenTracing Log Fields to an Event with the conventions outlined in the Exception semantic conventions document:

open-telemetry/opentelemetry-specification#1563

@robertsben
Copy link
Contributor

robertsben commented May 26, 2021

Hi, I'd opened this as a bug against the shim (#1870) having not seen this. Was wondering whether the intention was to address this in the shim, or whether you're looking to add it as a feature of the opentelemetry client (or collector) to translate the opentracing fields (error.kind->exception.type etc.) rather than directly emitting the opentelemetry ones (exception.type etc.)?

@srikanthccv
Copy link
Member

This should be addressed in shim package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants