Make setters and getters optional #1690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocelotl
force-pushed
the
issue_1644
branch
27 times, most recently
from
e6bbc99 to
48f1ede
Compare
ocelotl
force-pushed
the
issue_1644
branch
2 times, most recently
from
8c59877 to
6ef4756
Compare
lzchen
reviewed
Mar 26, 2021
lzchen
reviewed
Mar 26, 2021
lzchen
reviewed
Mar 26, 2021
Co-authored-by: Leighton Chen <lechen@microsoft.com>
Co-authored-by: Leighton Chen <lechen@microsoft.com>
Co-authored-by: Leighton Chen <lechen@microsoft.com>
codeboten
reviewed
Mar 26, 2021
| ) -> None: | ||
| """Uses the configured propagator to inject a Context into the carrier. | ||
|
|
||
| Args: | ||
| set_in_carrier: A setter function that can set values | ||
| setter: A `Setter` object that can set values |
There was a problem hiding this comment.
This should be moved to below the context, ditto with the getter documentation above.
Suggested change
| setter: A `Setter` object that can set values | |
| setter: An optional `Setter` object that can set values |
aabmass
approved these changes
Mar 26, 2021
owais
approved these changes
Mar 26, 2021
6 tasks
|
@aabmass @lonewolf3739 addressed the remaining comments, please take a quick look. |
codeboten
approved these changes
Mar 26, 2021
LGTM. |
This was referenced May 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes optional the setters and getters from
injectandextract.Fixes #1644
Description
Removes setters and getters
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Contrib Repo Change?
Checklist: