Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Protect against Propagators receiving null Getter/Setter #1644

Closed
carlosalberto opened this issue Feb 25, 2021 · 1 comment · Fixed by #1690
Closed

Protect against Propagators receiving null Getter/Setter #1644

carlosalberto opened this issue Feb 25, 2021 · 1 comment · Fixed by #1690
Assignees
@ocelotl
Labels
1.0.0rc2 release candidate 2 for tracing GA

Comments

@carlosalberto
Copy link
Contributor

Although this is not quite clear on the (very) general error handling recommendations, (and there's an ongoing issue in the Spec regarding this), I'd suggest ignoring a call when a Getter/Setter with a value of None is received, in order to not cause any error.
@ocelotl ocelotl self-assigned this Feb 25, 2021
@lzchen lzchen added the 1.0.0rc2 release candidate 2 for tracing GA label Feb 25, 2021
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Mar 11, 2021
@ocelotl
Remove setters and getters
7728ca0 
Fixes open-telemetry#1644
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Mar 11, 2021
@ocelotl
Remove setters and getters
263c140 
Fixes open-telemetry#1644
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Mar 11, 2021
@ocelotl
Remove setters and getters
30b3a60 
Fixes open-telemetry#1644
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Mar 11, 2021
@ocelotl
Remove setters and getters
39240ec 
Fixes open-telemetry#1644
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Mar 12, 2021
@ocelotl
Remove setters and getters
02c7d05 
Fixes open-telemetry#1644
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Mar 12, 2021
@ocelotl
Remove setters and getters
3c6583d 
Fixes open-telemetry#1644
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Mar 12, 2021
@ocelotl
Remove setters and getters
9f3017b 
Fixes open-telemetry#1644
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Mar 12, 2021
@ocelotl
Remove setters and getters
984b876 
Fixes open-telemetry#1644
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Mar 12, 2021
@ocelotl
Remove setters and getters
2abf55d 
Fixes open-telemetry#1644
@ocelotl ocelotl mentioned this issue Mar 12, 2021
Merged
11 tasks
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Mar 12, 2021
@ocelotl
Remove setters and getters
98ba890 
Fixes open-telemetry#1644
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Mar 12, 2021
@ocelotl
Remove setters and getters
50856f1 
Fixes open-telemetry#1644
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Mar 12, 2021
@ocelotl
Remove setters and getters
50fc7de 
Fixes open-telemetry#1644
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Mar 12, 2021
@ocelotl
Remove setters and getters
2644a80 
Fixes open-telemetry#1644
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Mar 12, 2021
@ocelotl
Remove setters and getters
6f67427 
Fixes open-telemetry#1644
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Mar 12, 2021
@ocelotl
Remove setters and getters
848e0ba 
Fixes open-telemetry#1644
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Mar 12, 2021
@ocelotl
Remove setters and getters
1b903a0 
Fixes open-telemetry#1644
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Mar 12, 2021
@ocelotl
Remove setters and getters
7fc47f8 
Fixes open-telemetry#1644
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Mar 12, 2021
@ocelotl
Remove setters and getters
3203f85 
Fixes open-telemetry#1644
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Mar 12, 2021
@ocelotl
Remove setters and getters
960663f 
Fixes open-telemetry#1644
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Mar 12, 2021
@ocelotl
Remove setters and getters
dbc3b1a 
Fixes open-telemetry#1644
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Mar 12, 2021
@ocelotl
Remove setters and getters
7d7b209 
Fixes open-telemetry#1644
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Mar 12, 2021
@ocelotl
Remove setters and getters
dc5ef2e 
Fixes open-telemetry#1644
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Mar 12, 2021
@ocelotl
Remove setters and getters
ce84e24 
Fixes open-telemetry#1644
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Mar 12, 2021
@ocelotl
Remove setters and getters
f4a0691 
Fixes open-telemetry#1644
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Mar 12, 2021
@ocelotl
Remove setters and getters
a21209e 
Fixes open-telemetry#1644
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Mar 12, 2021
@ocelotl
Remove setters and getters
1deb17b 
Fixes open-telemetry#1644
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Mar 12, 2021
@ocelotl
Remove setters and getters
1005fc1 
Fixes open-telemetry#1644
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Mar 12, 2021
@ocelotl
Remove setters and getters
677a2db 
Fixes open-telemetry#1644
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Mar 12, 2021
@ocelotl
Remove setters and getters
474a13e 
Fixes open-telemetry#1644
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Mar 12, 2021
@ocelotl
Remove setters and getters
4c65a08 
Fixes open-telemetry#1644
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Mar 12, 2021
@ocelotl
Remove setters and getters
54eb5c2 
Fixes open-telemetry#1644
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Mar 15, 2021
@ocelotl
Remove setters and getters
daeaca9 
Fixes open-telemetry#1644
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Mar 16, 2021
@ocelotl
Remove setters and getters
82b5cb6 
Fixes open-telemetry#1644
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Mar 16, 2021
@ocelotl
Remove setters and getters
1c228dd 
Fixes open-telemetry#1644
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Mar 16, 2021
@ocelotl
Remove setters and getters
e6bbc99 
Fixes open-telemetry#1644
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Mar 16, 2021
@ocelotl
Remove setters and getters
48f1ede 
Fixes open-telemetry#1644
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Mar 17, 2021
@ocelotl
Remove setters and getters
8c59877 
Fixes open-telemetry#1644
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Mar 17, 2021
@ocelotl
Remove setters and getters
6ef4756 
Fixes open-telemetry#1644
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Mar 17, 2021
@ocelotl
Remove setters and getters
e857a9a 
Fixes open-telemetry#1644
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Mar 17, 2021
@ocelotl
Remove setters and getters
eb670b5 
Fixes open-telemetry#1644
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Mar 17, 2021
@ocelotl
Remove setters and getters
e6e78e8 
Fixes open-telemetry#1644
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Mar 17, 2021
@ocelotl
Remove setters and getters
c62dca3 
Fixes open-telemetry#1644
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Mar 17, 2021
@ocelotl
Remove setters and getters
d44c00a 
Fixes open-telemetry#1644
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Mar 17, 2021
@ocelotl
Remove setters and getters
0f80fdc 
Fixes open-telemetry#1644
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Mar 17, 2021
@ocelotl
Remove setters and getters
1025652 
Fixes open-telemetry#1644
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Mar 17, 2021
@ocelotl
Remove setters and getters
33214ad 
Fixes open-telemetry#1644
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Mar 18, 2021
@ocelotl
Remove setters and getters
f110fc8 
Fixes open-telemetry#1644
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Mar 18, 2021
@ocelotl
Remove setters and getters
43a5fbd 
Fixes open-telemetry#1644
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Mar 18, 2021
@ocelotl
Remove setters and getters
6fddd5c 
Fixes open-telemetry#1644
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Mar 22, 2021
@ocelotl
Remove setters and getters
cf33931 
Fixes open-telemetry#1644
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Mar 22, 2021
@ocelotl
Remove setters and getters
8ec609f 
Fixes open-telemetry#1644
@ocelotl
Copy link
Contributor

ocelotl commented Mar 23, 2021

Although this is not quite clear on the (very) general error handling recommendations, (and there's an ongoing issue in the Spec regarding this), I'd suggest ignoring a call when a Getter/Setter with a value of None is received, in order to not cause any error.

Just for the record, I think this is the issue @carlosalberto is referring to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ocelotl ocelotl

Labels
1.0.0rc2 release candidate 2 for tracing GA
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make setters and getters optional ocelotl/opentelemetry-python
3 participants
@carlosalberto @ocelotl @lzchen