Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove rate property setter from TraceIdRatioBasedSampler #1536

Merged
merged 5 commits into from
Jan 19, 2021
Merged

Remove rate property setter from TraceIdRatioBasedSampler #1536

merged 5 commits into from
Jan 19, 2021

Conversation

srikanthccv
Copy link
Member

Description

From Sampler spec

GetDescription

Returns the sampler name or short description with the configuration. This may be displayed on debug pages or in the logs. Example: "TraceIdRatioBased{0.000100}".
Description MUST NOT change over time and caller can cache the returned value.

This implies rate should not be changed after instantiation, hence removing the rate setter from TraceIdRatioBasedSampler. Adding cache doesn't really change anything as there are no computationally expensive operations.

@srikanthccv srikanthccv requested review from a team, toumorokoshi and ocelotl and removed request for a team January 16, 2021 13:30
@srikanthccv srikanthccv reopened this Jan 16, 2021
toumorokoshi
toumorokoshi approved these changes Jan 19, 2021
View reviewed changes
Copy link
Member

@toumorokoshi toumorokoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Might be worth raising an issue to the spec to clarify that you can't change the sampler after instantiation.

@srikanthccv
Copy link
Member Author

LGTM. Might be worth raising an issue to the spec to clarify that you can't change the sampler after instantiation.

Yes, that would make it clear for others also. I will create an issue.

@lzchen lzchen merged commit c750109 into open-telemetry:master Jan 19, 2021
@srikanthccv srikanthccv deleted the remote-rate-setter branch September 24, 2021 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toumorokoshi toumorokoshi toumorokoshi approved these changes

@lzchen lzchen lzchen approved these changes

@ocelotl ocelotl Awaiting requested review from ocelotl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@srikanthccv @toumorokoshi @lzchen