Remove rate property setter from TraceIdRatioBasedSampler (#1536)

open-telemetry · Jan 19, 2021 · c750109 · c750109
1 parent d994e75
commit c750109
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -64,6 +64,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
   ([#1525](https://github.com/open-telemetry/opentelemetry-python/pull/1525))
 - `opentelemetry-exporter-jaeger`, `opentelemetry-exporter-zipkin` Update InstrumentationInfo tag keys for Jaeger and Zipkin exporters
   ([#1535](https://github.com/open-telemetry/opentelemetry-python/pull/1535))
+- `opentelemetry-sdk` Remove rate property setter from TraceIdRatioBasedSampler
+  ([#1536](https://github.com/open-telemetry/opentelemetry-python/pull/1536))
 
 ### Removed
 - `opentelemetry-api` Remove ThreadLocalRuntimeContext since python3.4 is not supported.

diff --git a/opentelemetry-sdk/src/opentelemetry/sdk/trace/sampling.py b/opentelemetry-sdk/src/opentelemetry/sdk/trace/sampling.py
@@ -233,11 +233,6 @@ def get_bound_for_rate(cls, rate: float) -> int:
     def rate(self) -> float:
         return self._rate
 
-    @rate.setter
-    def rate(self, new_rate: float) -> None:
-        self._rate = new_rate
-        self._bound = self.get_bound_for_rate(self._rate)
-
     @property
     def bound(self) -> int:
         return self._bound