Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sdk: rename resource labels to attributes #1082

Merged
merged 5 commits into from
Sep 9, 2020
Merged

sdk: rename resource labels to attributes #1082

merged 5 commits into from
Sep 9, 2020

Conversation

codeboten
Copy link
Contributor

Description

This aligns with the specification for Resources.

Fixes #1081

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

  • unit tests

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been updated
  • Documentation has been updated

Alex Boten added 2 commits September 8, 2020 09:10
@codeboten codeboten requested a review from a team September 8, 2020 16:21
@codeboten codeboten added the release:required-for-ga To be resolved before GA release label Sep 8, 2020
@codeboten codeboten merged commit 50478c2 into open-telemetry:master Sep 9, 2020
@aabmass aabmass mentioned this pull request Sep 9, 2020
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzchen lzchen lzchen approved these changes

@ocelotl ocelotl ocelotl approved these changes

Assignees
No one assigned
Labels
release:required-for-ga To be resolved before GA release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename Resource labels -> attributes
3 participants
@codeboten @ocelotl @lzchen