Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Resource labels -> attributes #1081

Closed
codeboten opened this issue Sep 8, 2020 · 0 comments · Fixed by #1082
Closed

Rename Resource labels -> attributes #1081

codeboten opened this issue Sep 8, 2020 · 0 comments · Fixed by #1082
Assignees
@codeboten
Labels
release:required-for-ga To be resolved before GA release sdk Affects the SDK package.

Comments

@codeboten
Copy link
Contributor

The spec has renamed Resource labels to attributes, the code in this repo still uses labels. This needs to be fixed.
@codeboten codeboten added sdk Affects the SDK package. release:required-for-ga To be resolved before GA release labels Sep 8, 2020
@codeboten codeboten self-assigned this Sep 8, 2020
@codeboten codeboten mentioned this issue Sep 8, 2020
Merged
6 tasks
srikanthccv pushed a commit to srikanthccv/opentelemetry-python that referenced this issue Nov 1, 2020
@dyladan
Move lint and doc check to actions (open-telemetry#1081)
d52026d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@codeboten codeboten

Labels
release:required-for-ga To be resolved before GA release sdk Affects the SDK package.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sdk: rename resource labels to attributes codeboten/opentelemetry-python
1 participant
@codeboten